Print Preview: Set a print job's title and url correctly.

chrome/browser/printing/print_view_manager.h

Index: chrome/browser/printing/print_view_manager.h
===================================================================
--- chrome/browser/printing/print_view_manager.h	(revision 80021)
+++ chrome/browser/printing/print_view_manager.h	(working copy)
@@ -32,6 +32,9 @@
   explicit PrintViewManager(TabContents* tab_contents);
   virtual ~PrintViewManager();
 
+  // Override the title and url for this PrintViewManager's PrintJobs.

[stuartmorgan, 2011/04/01 22:34:14]

The paramater is somewhat surprising given the description; can you flesh out
the description here to make it explicit that it's extract the tab_contents
title and URL to use?

[Lei Zhang, 2011/04/04 22:21:03]

Done.

+  void OverrideTitleAndUrl(TabContents* tab_contents);
+
   // PrintedPagesSource implementation.
   virtual string16 RenderSourceName();
   virtual GURL RenderSourceUrl();
@@ -128,6 +131,11 @@
   bool expecting_first_page_;
 #endif
 
+  // Title and URL overrides.
+  bool overridden_title_url_;

[stuartmorgan, 2011/04/01 22:34:14]

overridden_title_and_url_ ? I was trying to figure out what a title_url was for
a minute.

+  string16 overridden_title_;
+  GURL overridden_url_;
+
   DISALLOW_COPY_AND_ASSIGN(PrintViewManager);
 };