Print Preview: Set a print job's title and url correctly.

chrome/browser/printing/print_view_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PRINTING_PRINT_VIEW_MANAGER_H_
 #define CHROME_BROWSER_PRINTING_PRINT_VIEW_MANAGER_H_
 #pragma once
 
 #include "base/memory/ref_counted.h"
 #include "base/string16.h"
@@ skipping 14 matching lines @@
 
 // Manages the print commands in relation to a TabContents. TabContents
 // delegates a few printing related commands to this instance.
 class PrintViewManager : public NotificationObserver,
                          public PrintedPagesSource,
                          public TabContentsObserver {
  public:
   explicit PrintViewManager(TabContents* tab_contents);
   virtual ~PrintViewManager();
 
+  // Override the title and url for this PrintViewManager's PrintJobs.

[stuartmorgan, 2011/04/01 22:34:14]

The paramater is somewhat surprising given the description; can you flesh out
the description here to make it explicit that it's extract the tab_contents
title and URL to use?

[Lei Zhang, 2011/04/04 22:21:03]

Done.

+  void OverrideTitleAndUrl(TabContents* tab_contents);
+
   // PrintedPagesSource implementation.
   virtual string16 RenderSourceName();
   virtual GURL RenderSourceUrl();
 
   // NotificationObserver implementation.
   virtual void Observe(NotificationType type,
                        const NotificationSource& source,
                        const NotificationDetails& details);
 
   // TabContentsObserver implementation.
@@ skipping 76 matching lines @@
   // Running an inner message loop inside RenderAllMissingPagesNow(). This means
   // we are _blocking_ until all the necessary pages have been rendered or the
   // print settings are being loaded.
   bool inside_inner_message_loop_;
 
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
   // Set to true when OnDidPrintPage() should be expecting the first page.
   bool expecting_first_page_;
 #endif
 
+  // Title and URL overrides.
+  bool overridden_title_url_;

[stuartmorgan, 2011/04/01 22:34:14]

overridden_title_and_url_ ? I was trying to figure out what a title_url was for
a minute.

+  string16 overridden_title_;
+  GURL overridden_url_;
+
   DISALLOW_COPY_AND_ASSIGN(PrintViewManager);
 };
 
 }  // namespace printing
 
 #endif  // CHROME_BROWSER_PRINTING_PRINT_VIEW_MANAGER_H_