download_action.cc - Issue 6778029: AU: detect failure when using public key verification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: download_action.cc

Issue 6778029: AU: detect failure when using public key verification (Closed) Base URL: http://git.chromium.org/git/update_engine.git@master

Patch Set: fix NULL checks Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: download_action.cc

diff --git a/download_action.cc b/download_action.cc

index d6ae97dfefc5eec167fab74d725b7aba6ae85d33..9577047de5f49c55fc6d6540baf02edc50ba7a05 100644

--- a/download_action.cc

+++ b/download_action.cc

@@ -163,7 +163,8 @@ void DownloadAction::TransferComplete(HttpFetcher *fetcher, bool successful) {

if (!install_plan_.is_full_update) {

if (!delta_performer_->VerifyPayload("",

install_plan_.download_hash,

- install_plan_.size)) {

+ install_plan_.size,

+ NULL)) {

petkov 2011/03/30 22:36:23 Intentionally removed the TODO, I assume?

adlr 2011/04/04 23:27:13 Yeah, I think it makes this CL cleaner

LOG(ERROR) << "Download of " << install_plan_.download_url

<< " failed due to payload verification error.";

code = kActionCodeDownloadPayloadVerificationError;

« no previous file with comments | « delta_performer_unittest.cc ('k') | no next file » | no next file with comments »