AU: detect failure when using public key verification

download_action.cc

 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "update_engine/download_action.h"
 #include <errno.h>
 #include <algorithm>
 #include <string>
 #include <vector>
 #include <glib.h>
@@ skipping 145 matching lines @@
   }
   if (delegate_) {
     delegate_->SetDownloadStatus(false);  // Set to inactive.
   }
   ActionExitCode code =
       successful ? kActionCodeSuccess : kActionCodeDownloadTransferError;
   if (code == kActionCodeSuccess) {
     if (!install_plan_.is_full_update) {
       if (!delta_performer_->VerifyPayload("",
                                            install_plan_.download_hash,
-                                           install_plan_.size)) {
+                                           install_plan_.size,
+                                           NULL)) {

[petkov, 2011/03/30 22:36:23]

Intentionally removed the TODO, I assume?

[adlr, 2011/04/04 23:27:13]

Yeah, I think it makes this CL cleaner

         LOG(ERROR) << "Download of " << install_plan_.download_url
                    << " failed due to payload verification error.";
         code = kActionCodeDownloadPayloadVerificationError;
       } else if (!delta_performer_->GetNewPartitionInfo(
           &install_plan_.kernel_size,
           &install_plan_.kernel_hash,
           &install_plan_.rootfs_size,
           &install_plan_.rootfs_hash)) {
         LOG(ERROR) << "Unable to get new partition hash info.";
         code = kActionCodeDownloadNewPartitionInfoError;
@@ skipping 23 matching lines @@
   processor_->ActionComplete(this, code);
 }
 
 void DownloadAction::TransferTerminated(HttpFetcher *fetcher) {
   if (code_ != kActionCodeSuccess) {
     processor_->ActionComplete(this, code_);
   }
 }
 
 };  // namespace {}