Issue 6773023: Add Naver Nanum fonts (OFL)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6773023: Add Naver Nanum fonts (OFL) (Closed)

Created:
9 years, 9 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
use derat at chromium.org, Daniel Erat

CC:
chromium-os-reviews_chromium.org, msb+crosoverlay_chromium.org, adlr+crosoverlay_chromium.org, anush

Base URL:
ssh://gitrw.chromium.org:9222/chromiumos-overlay.git@master

Visibility:
Public.

Description

Add Naver Nanum fonts (OFL) - Adds ko-nanumfonts-3.10.0 ebuild for Naver Nanum fonts. - We're getting NanumMyeongjo/Gothic (Regular and Bold) from the local mirror (instead of the upstream download URL) to have a version associated with tar ball. Otherwise, our build will break due to a check-sum mismatch because the upstream zip file does not have a version number attached to the file name. Our tar ball also drops ExtraBold and Brush/Pen for now and adds LICENSE file so that os-credit page shows its license. - The version I used is the version of NanumGothic.ttf. - Modify local.conf to use Nanum fonts instead of Gulim/Batang fonts for Korean. - Remove the references to Ascender {Sans,Serif,Sans Mono} because they're not used any more. OTA impact: 14MB of new fonts. However, it should of considered along with the fact that about 30MB of disk footprint is reduced by removing licensed Korean fonts from Google ChromeOS. BUG=chromium-os:8643 TEST=emerge ko-nanumfonts works fine. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=74ac59f

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -16 lines)			Patch
M	chromeos-base/chromeos/chromeos-0.0.1.ebuild	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
D	chromeos-base/chromeos/chromeos-0.0.1-r110.ebuild	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
A +	chromeos-base/chromeos/chromeos-0.0.1-r111.ebuild	View	1 2 3 4	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	media-fonts/ko-nanumfonts/ko-nanumfonts-3.10.0.ebuild	View	1 2 3	1 chunk	+29 lines, -0 lines	0 comments	Download
M	media-libs/fontconfig/files/local.conf	View	1 2 3	9 chunks	+54 lines, -16 lines	0 comments	Download
D	media-libs/fontconfig/fontconfig-2.7.1-r17.ebuild	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
A +	media-libs/fontconfig/fontconfig-2.7.1-r18.ebuild	View	1 2 3 4	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	profiles/targets/chromeos/package.use.mask	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

9 years, 8 months ago (2011-04-15 20:47:34 UTC) #1

LGTM

http://codereview.chromium.org/6773023/diff/6001/media-libs/fontconfig/files/...
File media-libs/fontconfig/files/local.conf (right):

http://codereview.chromium.org/6773023/diff/6001/media-libs/fontconfig/files/...
media-libs/fontconfig/files/local.conf:408: 
nit: remove these extra blank lines?

Expand Messages | Collapse Messages

Issue 6773023: Add Naver Nanum fonts (OFL) (Closed)

Description

Patch Set 1 #

Patch Set 2 : remove Pen/Brush/ExtraBold #

Patch Set 3 : chromeos-ebuild and package.use.mask change #

Patch Set 4 : fontconfig,ebuild update #

Patch Set 5 : merge to head #

Messages