Add the ability to pass use flags through cbuildbot to build_packages.

Add the ability to pass use flags through cbuildbot to build_packages.

Change-Id: I0e069217dd57c0c5f916da7152f3674849ce8469

BUG=http://code.google.com/p/chromium/issues/detail?id=78345
TEST=manual: a -full ( nousepkg ), a -bin (no extra), a useflag single, and a useflag multiple.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=edbd709

[Peter Mayo, 2011-03-31 06:49:47]

This seems like a reasonable way to specify USE flags.

Tested a -full ( nousepkg ), a -bin (no extra), a useflag single, and a useflag
multiple.

This makes build options specifiable to cbuildbot_config.py, for example.

[Peter Mayo, 2011-03-31 15:05:04]

http://codereview.chromium.org/6773013/diff/2001/buildbot/cbuildbot_commands.py
File buildbot/cbuildbot_commands.py (right):

http://codereview.chromium.org/6773013/diff/2001/buildbot/cbuildbot_commands....
buildbot/cbuildbot_commands.py:162: if emptytree:
In your review, please consider and record an opinion on whether it would be
better to move the definition of emptytree up into the "_stages" layer, leave as
it is here, or move the interpretation of the useflags as an environment
variable down into the "_command" (so that Build contains all of the knowledge
of how build_packages functions).

[sosa, 2011-04-01 00:01:11]

I'm not sure how I feel about this change since these configs are fairly static.
 Do you imagine many different builders with different sets of USE flags being
passed here ... or just one known set for a specific type of builder.  If
there's a fixed set of USE flags, I"d rather not add the flexibility of
arbitrary use flags and have those USE flags specified given if that type is
set.

http://codereview.chromium.org/6773013/diff/2001/buildbot/cbuildbot_stages.py
File buildbot/cbuildbot_stages.py (right):

http://codereview.chromium.org/6773013/diff/2001/buildbot/cbuildbot_stages.py...
buildbot/cbuildbot_stages.py:324: if isinstance(self._build_config['useflags'],
basestring):
Choose one or the other ...i.e. allow string or array, don't allow both.

http://codereview.chromium.org/6773013/diff/2001/buildbot/cbuildbot_stages.py...
buildbot/cbuildbot_stages.py:329: # TODO(petermayo): Add other extra env
variable when asked.
Remove this TODO

[Peter Mayo, 2011-04-01 02:43:55]

On 2011/04/01 00:01:11, sosa wrote:
>  Do you imagine many different builders with different sets of USE flags being
> passed here ... or just one known set for a specific type of builder.  If
> there's a fixed set of USE flags, I"d rather not add the flexibility of
> arbitrary use flags and have those USE flags specified given if that type is
> set.

I imagine a small but not necessarily known a-priori set of values for USE
flags.  I have seen a hand full around, with more resistance to changing the
plumbing than adding a new value for a sub-group to use.  (no pun intended)

[Peter Mayo, 2011-04-01 02:46:05]

http://codereview.chromium.org/6773013/diff/2001/buildbot/cbuildbot_stages.py
File buildbot/cbuildbot_stages.py (right):

http://codereview.chromium.org/6773013/diff/2001/buildbot/cbuildbot_stages.py...
buildbot/cbuildbot_stages.py:324: if isinstance(self._build_config['useflags'],
basestring):
On 2011/04/01 00:01:11, sosa wrote:
> Choose one or the other ...i.e. allow string or array, don't allow both.

I think array may eventually be required, but since a string can be used as an
array, if you pass a string you end up with a  d o u b l e  s p a c e d 
version.

Done

http://codereview.chromium.org/6773013/diff/2001/buildbot/cbuildbot_stages.py...
buildbot/cbuildbot_stages.py:329: # TODO(petermayo): Add other extra env
variable when asked.
On 2011/04/01 00:01:11, sosa wrote:
> Remove this TODO

Done.

[sosa, 2011-04-02 00:41:08]

Please file a bug before committing for this CL.  Otherwise,  LGTM

[kliegs, 2011-04-04 16:49:35]

Oops. Forgot to sign off.

LGTM

On 2011/04/02 00:41:08, sosa wrote:
> Please file a bug before committing for this CL.  Otherwise,  LGTM