Add the ability to pass use flags through cbuildbot to build_packages.

buildbot/cbuildbot_commands.py

 # Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Module containing the various individual commands a builder can run."""
 
 import os
 import re
 import shutil
 import sys
@@ skipping 133 matching lines @@
   cros_lib.OldRunCommand(cmd, cwd=cwd)
 
 
 def SetupBoard(buildroot, board='x86-generic'):
   """Wrapper around setup_board."""
   cwd = os.path.join(buildroot, 'src', 'scripts')
   cros_lib.OldRunCommand(
       ['./setup_board', '--fast', '--default', '--board=%s' % board], cwd=cwd,
       enter_chroot=True)
 
-
-def Build(buildroot, emptytree, build_autotest=True, usepkg=True):
+def Build(buildroot, emptytree, build_autotest=True, usepkg=True,
+          extra_env=None):
   """Wrapper around build_packages."""
   cwd = os.path.join(buildroot, 'src', 'scripts')
   cmd = ['./build_packages']
+  env = []
   if not build_autotest: cmd.append('--nowithautotest')
   if not usepkg: cmd.append('--nousepkg')
   if emptytree:

[Peter Mayo, 2011/03/31 15:05:04]

In your review, please consider and record an opinion on whether it would be
better to move the definition of emptytree up into the "_stages" layer, leave as
it is here, or move the interpretation of the useflags as an environment
variable down into the "_command" (so that Build contains all of the knowledge
of how build_packages functions).

-    cmd = ['sh', '-c', 'EXTRA_BOARD_FLAGS=--emptytree %s' % ' '.join(cmd)]
+    env.append('EXTRA_BOARD_FLAGS=--emptytree')
+  if extra_env:
+    env.extend(extra_env)
+  if env:
+    cmd = ['sh', '-c', '%s %s' % (' '.join(env), ' '.join(cmd))]
 
   cros_lib.OldRunCommand(cmd, cwd=cwd, enter_chroot=True)
 
 
 def BuildImage(buildroot):
   _WipeOldOutput(buildroot)
 
   cwd = os.path.join(buildroot, 'src', 'scripts')
   cros_lib.OldRunCommand(['./build_image', '--replace'], cwd=cwd,
                          enter_chroot=True)
@@ skipping 269 matching lines @@
 
   archive_url = None
   key_re = re.compile('^%s=(.*)$' % _CROS_ARCHIVE_URL)
   for line in result.output.splitlines():
     line_match = key_re.match(line)
     if line_match:
       archive_url = line_match.group(1)
 
   assert archive_url, 'Archive Build Failed to Provide Archive URL'
   return archive_url