Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 6771058: Support placement new syntax for zone objects and start using it in the parser. (Closed)

Created:
9 years, 8 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Support placement new syntax for zone objects and start using it in the parser.

Patch Set 1 #

Patch Set 2 : Update RegExpBuilder #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -117 lines) Patch
M src/parser.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M src/parser.cc View 1 79 chunks +128 lines, -117 lines 1 comment Download
M src/zone.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/zone-inl.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Repeshko
9 years, 8 months ago (2011-04-01 16:55:25 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/6771058/diff/3001/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/6771058/diff/3001/src/parser.cc#newcode105 src/parser.cc:105: RegExpTree* atom = new(zone()) RegExpAtom(characters_->ToConstVector()); We have to ...
9 years, 8 months ago (2011-04-01 17:08:38 UTC) #2
Vitaly Repeshko
9 years, 8 months ago (2011-04-04 06:29:41 UTC) #3
Thanks for the review. You're right, placement new syntax doesn't seem to be
covered by the style guide, but a) the no-space variant is more common in the
chromium sources (including existing usages in v8) and b) if the space is added
it makes the lint unhappy (it confuses "new" with a function call). Landed with
no space.

Powered by Google App Engine
This is Rietveld 408576698