More filesystem cleanup: convert URL-encoded-as-FilePath to actual URL, where

webkit/fileapi/file_system_path_manager.h

Index: webkit/fileapi/file_system_path_manager.h
===================================================================
--- webkit/fileapi/file_system_path_manager.h	(revision 79631)
+++ webkit/fileapi/file_system_path_manager.h	(working copy)
@@ -68,14 +68,6 @@
       FileSystemType type,
       const FilePath& virtual_path,
       bool create);
-  // Cracks the given |path|, retrieves the information embedded in the path
-  // and populates |origin_url|, |type| and |virtual_path|.  The |virtual_path|
-  // is a sandboxed path in the file system, i.e. the relative path to the
-  // filesystem root for the given domain and type.
-  bool CrackFileSystemPath(const FilePath& path,

[zel, 2011/04/06 21:43:00]

eric, my new CL relies heavily on this function - for both path parsing and
permission checks. I see that you are using CrackFileSystemURL() instead, but
that one does not check permissions - right?

[ericu, 2011/04/06 23:30:36]

Right--now that we've only got URLs, not paths, there's just the one method. 
Rather than put the new permission-check method in here, I decided it was
cleaner just to let this stay a pure cracking function, so if you want the
security checks, you'll have to call the new method directly.

-                           GURL* origin_url,
-                           FileSystemType* type,
-                           FilePath* virtual_path) const;
 
   // Returns true if the given |url|'s scheme is allowed to access
   // filesystem.