More filesystem cleanup: convert URL-encoded-as-FilePath to actual URL, where

webkit/fileapi/file_system_path_manager.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_FILE_SYSTEM_PATH_MANAGER_H_
 #define WEBKIT_FILEAPI_FILE_SYSTEM_PATH_MANAGER_H_
 #pragma once
 
 #include "base/callback.h"
 #include "base/file_path.h"
@@ skipping 50 matching lines @@
                              FileSystemPathManager::GetRootPathCallback*
                                  callback);
 
   // Like GetFileSystemRootPath, but synchronous, and can be called only while
   // running on the file thread.
   virtual FilePath GetFileSystemRootPathOnFileThread(
       const GURL& origin_url,
       FileSystemType type,
       const FilePath& virtual_path,
       bool create);
-  // Cracks the given |path|, retrieves the information embedded in the path
-  // and populates |origin_url|, |type| and |virtual_path|.  The |virtual_path|
-  // is a sandboxed path in the file system, i.e. the relative path to the
-  // filesystem root for the given domain and type.
-  bool CrackFileSystemPath(const FilePath& path,

[zel, 2011/04/06 21:43:00]

eric, my new CL relies heavily on this function - for both path parsing and
permission checks. I see that you are using CrackFileSystemURL() instead, but
that one does not check permissions - right?

[ericu, 2011/04/06 23:30:36]

Right--now that we've only got URLs, not paths, there's just the one method. 
Rather than put the new permission-check method in here, I decided it was
cleaner just to let this stay a pure cracking function, so if you want the
security checks, you'll have to call the new method directly.

-                           GURL* origin_url,
-                           FileSystemType* type,
-                           FilePath* virtual_path) const;
 
   // Returns true if the given |url|'s scheme is allowed to access
   // filesystem.
   bool IsAllowedScheme(const GURL& url) const;
 
   // Returns the string for the given |type|.
   // Returns an empty string if the |type| is invalid.
   static std::string GetFileSystemTypeString(fileapi::FileSystemType type);
 
   // Checks if a given |name| contains any restricted names/chars in it.
@@ skipping 13 matching lines @@
   const bool allow_file_access_from_files_;
   scoped_ptr<SandboxMountPointProvider> sandbox_provider_;
   scoped_ptr<FileSystemMountPointProvider> local_provider_;
 
   DISALLOW_COPY_AND_ASSIGN(FileSystemPathManager);
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_FILEAPI_FILE_SYSTEM_PATH_MANAGER_H_