Replace bools in extension creation with flags.

Replace bools in extension creation with flags.

Turn require_key and strict_error_checks bool params of Extension::
InitFromValue, Extension::Create and extension_file_util::LoadExtension into a
flags parameter.

BUG=None
TEST=compiles
R=aa@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79638

[Aaron Boodman, 2011-03-28 23:26:40]

lgtm

http://codereview.chromium.org/6766002/diff/1/chrome/common/extensions/extens...
File chrome/common/extensions/extension.h (right):

http://codereview.chromium.org/6766002/diff/1/chrome/common/extensions/extens...
chrome/common/extensions/extension.h:119: // Usually, the id of an extension is
generated by the "key" property of
Add a blank line between each item?

http://codereview.chromium.org/6766002/diff/1/chrome/common/extensions/extens...
chrome/common/extensions/extension.h:139: int flags,
I always forget: Can you define this as InitFromValueFlags even when it might be
a bitmask at runtime? I feel like I've seen some people doing this in C++, but I
might be making that up.

[Mihai Parparita -not on Chrome, 2011-03-28 23:37:48]

On Mon, Mar 28, 2011 at 4:26 PM,  <aa@chromium.org> wrote:
>
http://codereview.chromium.org/6766002/diff/1/chrome/common/extensions/extens...
> chrome/common/extensions/extension.h:119: // Usually, the id of an
> extension is generated by the "key" property of
> Add a blank line between each item?

Dpne.

>
http://codereview.chromium.org/6766002/diff/1/chrome/common/extensions/extens...
> chrome/common/extensions/extension.h:139: int flags,
> I always forget: Can you define this as InitFromValueFlags even when it
> might be a bitmask at runtime? I feel like I've seen some people doing
> this in C++, but I might be making that up.

The obvious thing (making the type be InitFromValueFlags) doesn't
compile, and I don't think adding casts everywhere is a good idea.

Mihai

[Aaron Boodman, 2011-03-28 23:40:31]

On Mon, Mar 28, 2011 at 4:37 PM, Mihai Parparita <mihaip@chromium.org> wrote:
>>
http://codereview.chromium.org/6766002/diff/1/chrome/common/extensions/extens...
>> chrome/common/extensions/extension.h:139: int flags,
>> I always forget: Can you define this as InitFromValueFlags even when it
>> might be a bitmask at runtime? I feel like I've seen some people doing
>> this in C++, but I might be making that up.
>
> The obvious thing (making the type be InitFromValueFlags) doesn't
> compile, and I don't think adding casts everywhere is a good idea.

Ok.