Replace bools in extension creation with flags.

chrome/common/extensions/extension.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 96 matching lines @@
     std::string gender;
   };
 
   // A permission is defined by its |name| (what is used in the manifest),
   // and the |message_id| that's used by install/update UI.
   struct Permission {
     const char* const name;
     const int message_id;
   };
 
-  // |strict_error_checks| enables extra error checking, such as
-  // checks that URL patterns do not contain ports.  This error
-  // checking may find an error that a previous version of
-  // chrome did not flag.  To avoid errors in installed extensions
-  // when chrome is upgraded, strict error checking is only enabled
-  // when loading extensions as a developer would (such as loading
-  // an unpacked extension), or when loading an extension that is
-  // tied to a specific version of chrome (such as a component
-  // extension).  Most callers will set |strict_error_checks| to
-  // Extension::ShouldDoStrictErrorChecking(location).
+  enum InitFromValueFlags {
+    NO_FLAGS = 0,
+    // Usually, the id of an extension is generated by the "key" property of

[Aaron Boodman, 2011/03/28 23:26:40]

Add a blank line between each item?

+    // its manifest, but if |REQUIRE_KEY| is not set, a temporary ID will be
+    // generated based on the path.
+    REQUIRE_KEY = 1 << 0,
+    // |STRICT_ERROR_CHECKS| enables extra error checking, such as
+    // checks that URL patterns do not contain ports.  This error
+    // checking may find an error that a previous version of
+    // Chrome did not flag.  To avoid errors in installed extensions
+    // when Chrome is upgraded, strict error checking is only enabled
+    // when loading extensions as a developer would (such as loading
+    // an unpacked extension), or when loading an extension that is
+    // tied to a specific version of Chrome (such as a component
+    // extension).  Most callers will set the |STRICT_ERROR_CHECKS| bit when
+    // Extension::ShouldDoStrictErrorChecking(location) returns true.
+    STRICT_ERROR_CHECKS = 1 << 1,
+  };
+
   static scoped_refptr<Extension> Create(const FilePath& path,
                                          Location location,
                                          const DictionaryValue& value,
-                                         bool require_key,
-                                         bool strict_error_checks,
+                                         int flags,

[Aaron Boodman, 2011/03/28 23:26:40]

I always forget: Can you define this as InitFromValueFlags even when it might be
a bitmask at runtime? I feel like I've seen some people doing this in C++, but I
might be making that up.

                                          std::string* error);
 
   // Return the update url used by gallery/webstore extensions.
   static GURL GalleryUpdateUrl(bool secure);
 
   // The install message id for |permission|.  Returns 0 if none exists.
   static int GetPermissionMessageId(const std::string& permission);
 
   // Returns the full list of permission messages that this extension
   // should display at install time.
@@ skipping 390 matching lines @@
   // If you need to compare two URLPatternLists for security equality, then set
   // |include_rcd| to false, which will return a result like "*.google.",
   // regardless of the order of the patterns.
   static std::vector<std::string> GetDistinctHosts(
       const URLPatternList& host_patterns, bool include_rcd);
 
   Extension(const FilePath& path, Location location);
   ~Extension();
 
   // Initialize the extension from a parsed manifest.
-  // Usually, the id of an extension is generated by the "key" property of
-  // its manifest, but if |require_key| is |false|, a temporary ID will be
-  // generated based on the path.
-  bool InitFromValue(const DictionaryValue& value, bool require_key,
-                     bool strict_error_checks, std::string* error);
+  bool InitFromValue(const DictionaryValue& value, int flags,
+                     std::string* error);
 
   // Helper function for implementing HasCachedImage/GetCachedImage. A return
   // value of NULL means there is no matching image cached (we allow caching an
   // empty SkBitmap).
   SkBitmap* GetCachedImageImpl(const ExtensionResource& source,
                                const gfx::Size& max_size) const;
 
   // Helper method that loads a UserScript object from a
   // dictionary in the content_script list of the manifest.
   bool LoadUserScriptHelper(const DictionaryValue* content_script,
@@ skipping 268 matching lines @@
   // Was the extension already disabled?
   bool already_disabled;
 
   // The extension being unloaded - this should always be non-NULL.
   const Extension* extension;
 
   UnloadedExtensionInfo(const Extension* extension, Reason reason);
 };
 
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_H_