Issue 6765005: Add tidy to build deps for hdctools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6765005: Add tidy to build deps for hdctools (Closed)

Created:
9 years, 9 months ago by tbroch1

Modified:
9 years, 7 months ago

Reviewers:
Mandeep Singh Baines, anush

CC:
chromium-os-reviews_chromium.org, msb+crosoverlay_chromium.org, adlr+crosoverlay_chromium.org, anush

Base URL:
ssh://gitrw.chromium.org:9222/chromiumos-overlay.git@master

Visibility:
Public.

Description

Add tidy to build deps hdctools tidy is used in servo/data/ina219.py to make the xml pretty. Related CL: https://chromereviews.googleplex.com/2669051/ BUG=chrome-os-partner:2793 TEST=manual chroot> emerge -1 hdctools look at /usr/lib64/python2.6/site-packages/servo/data/wario.xml and make sure its tidy Change-Id: I865cf0531155a59b2cb5be5f5752f50439195d31 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=423164d

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	dev-util/hdctools/hdctools-9999.ebuild	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tbroch1

See related CL for dep to tidy explanation. Thanks for reviewing

9 years, 9 months ago (2011-03-28 21:09:58 UTC) #1

tbroch1

PTAL On 2011/03/28 21:09:58, tbroch1 wrote: > See related CL for dep to tidy explanation. ...

9 years, 8 months ago (2011-04-02 02:06:53 UTC) #2

anush

9 years, 8 months ago (2011-04-07 18:49:00 UTC) #3

LGTM

On Fri, Apr 1, 2011 at 7:06 PM, <tbroch@chromium.org> wrote:

> PTAL
>
> On 2011/03/28 21:09:58, tbroch1 wrote:
>
>> See related CL for dep to tidy explanation.
>>
>
>  Thanks for reviewing
>>
>
>
>
> http://codereview.chromium.org/6765005/
>

Expand Messages | Collapse Messages