Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: README.chromium

Issue 6760010: Fixing icu to work with msvs2010. (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/deps/third_party/icu46/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | source/common/stringpiece.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.chromium
===================================================================
--- README.chromium (revision 79633)
+++ README.chromium (working copy)
@@ -137,3 +137,16 @@
source/common/unicode ==> public/common/unicode
source/i18n/unicode ==> public/i18n/unicode
+12. Fix for msvs2010 applied:
+--- D:/src/ent/src/third_party/icu/source/common/stringpiece.cpp
+ (revision 78292)
++++ D:/src/ent/src/third_party/icu/source/common/stringpiece.cpp
+ (working copy)
+@@ -75,7 +75,7 @@
+ * Visual Studios 9.0.
+ * Cygwin with MSVC 9.0 also complains here about redefinition.
+ */
+-#if (!defined(_MSC_VER) || (_MSC_VER > 1500)) && !defined(CYGWINMSVC)
++#if (!defined(_MSC_VER) || (_MSC_VER > 1600)) && !defined(CYGWINMSVC)
+ const int32_t StringPiece::npos;
+ #endif
« no previous file with comments | « no previous file | source/common/stringpiece.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698