README.chromium - Issue 6760010: Fixing icu to work with msvs2010.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: README.chromium

Issue 6760010: Fixing icu to work with msvs2010. (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/deps/third_party/icu46/

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name: icu	1 Name: icu

2 URL: http://site.icu-project.org/	2 URL: http://site.icu-project.org/

3 Version: 4.6	3 Version: 4.6

4	4

5 Description:	5 Description:

6 This directory contains the source code of ICU 4.6 for C/C++	6 This directory contains the source code of ICU 4.6 for C/C++

7	7

8 1. It was obtained with the following:	8 1. It was obtained with the following:

9	9

10 $ svn export --native-eol LF http://source.icu-project.org/repos/icu/icu/tag s/release-4-6 icu46	10 $ svn export --native-eol LF http://source.icu-project.org/repos/icu/icu/tag s/release-4-6 icu46

(...skipping 119 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
130 - cros/icudt46l_dat.S : Built on Linux with	130 - cros/icudt46l_dat.S : Built on Linux with

131 abriged locale source files in cros/data put	131 abriged locale source files in cros/data put

132 in source/data. Those abridged locales files are	132 in source/data. Those abridged locales files are

133 for locales ChromeOS is not localized to.	133 for locales ChromeOS is not localized to.

134	134

135 11. The header files were moved as shown below:	135 11. The header files were moved as shown below:

136	136

137 source/common/unicode ==> public/common/unicode	137 source/common/unicode ==> public/common/unicode

138 source/i18n/unicode ==> public/i18n/unicode	138 source/i18n/unicode ==> public/i18n/unicode

139	139

	140 12. Fix for msvs2010 applied:

	141 --- D:/src/ent/src/third_party/icu/source/common/stringpiece.cpp

	142 (revision 78292)

	143 +++ D:/src/ent/src/third_party/icu/source/common/stringpiece.cpp

	144 (working copy)

	145 @@ -75,7 +75,7 @@

	146 * Visual Studios 9.0.

	147 * Cygwin with MSVC 9.0 also complains here about redefinition.

	148 */

	149 -#if (!defined(_MSC_VER) \|\| (_MSC_VER > 1500)) && !defined(CYGWINMSVC)

	150 +#if (!defined(_MSC_VER) \|\| (_MSC_VER > 1600)) && !defined(CYGWINMSVC)

	151 const int32_t StringPiece::npos;

	152 #endif

OLD	NEW

« no previous file with comments | « no previous file | source/common/stringpiece.cpp » ('j') | no next file with comments »