Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 6759048: Use system constants instead of NULL for unset PID. (Closed)

Created:
9 years, 8 months ago by Jeff Bailey (chromium)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jam, apatrick_chromium, brettw-cc_chromium.org
Visibility:
Public.

Description

Use system constants instead of NULL for unset PID. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80225

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M base/process.h View 1 chunk +2 lines, -0 lines 2 comments Download
M content/gpu/gpu_channel.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
amit
lgtm with a nit. http://codereview.chromium.org/6759048/diff/1/base/process.h File base/process.h (right): http://codereview.chromium.org/6759048/diff/1/base/process.h#newcode28 base/process.h:28: const ProcessId kNullProcessId = NULL; ...
9 years, 8 months ago (2011-04-01 05:15:12 UTC) #1
Jeff Bailey (chromium)
Thanks. Will do one more pass through the try bots to be sure. http://codereview.chromium.org/6759048/diff/1/base/process.h File ...
9 years, 8 months ago (2011-04-01 05:26:09 UTC) #2
Ken Russell (switch to Gerrit)
9 years, 8 months ago (2011-04-01 18:13:59 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698