Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: base/process.h

Issue 6759048: Use system constants instead of NULL for unset PID. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/gpu/gpu_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process.h
===================================================================
--- base/process.h (revision 80123)
+++ base/process.h (working copy)
@@ -25,11 +25,13 @@
typedef DWORD ProcessId;
typedef HANDLE UserTokenHandle;
const ProcessHandle kNullProcessHandle = NULL;
+const ProcessId kNullProcessId = NULL;
amit 2011/04/01 05:15:12 Since PricessId is a DWORD here, why not = 0?
Jeff Bailey (chromium) 2011/04/01 05:26:09 Had to look up what a DWORD was. Will change is.
#elif defined(OS_POSIX)
// On POSIX, our ProcessHandle will just be the PID.
typedef pid_t ProcessHandle;
typedef pid_t ProcessId;
const ProcessHandle kNullProcessHandle = 0;
+const ProcessId kNullProcessId = 0;
#endif // defined(OS_WIN)
#if defined(OS_POSIX) && !defined(OS_MACOSX)
« no previous file with comments | « no previous file | content/gpu/gpu_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698