Issue 6758014: PrintPreview: Added a helper function to get print job settings from dictionary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6758014: PrintPreview: Added a helper function to get print job settings from dictionary. (Closed)

Created:
9 years, 8 months ago by kmadhusu

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

PrintPreview: Added a helper function to get print job settings from dictionary. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80008

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : Addressed review comments #

Patch Set 4 : Fix mac build error. #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -12 lines)			Patch
M	printing/printing_context.h	View	1 2 3	1 chunk	+7 lines, -0 lines	0 comments	Download
M	printing/printing_context.cc	View	1 2 3	2 chunks	+17 lines, -1 line	0 comments	Download
M	printing/printing_context_cairo.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	printing/printing_context_mac.mm	View	1	2 chunks	+3 lines, -6 lines	0 comments	Download
M	printing/printing_context_win.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

LGTM since this is what I wanted in the first place. http://codereview.chromium.org/6758014/diff/1001/printing/printing_context.cc File printing/printing_context.cc (right): ...

9 years, 8 months ago (2011-03-30 22:12:00 UTC) #2

kmadhusu

9 years, 8 months ago (2011-03-30 22:18:47 UTC) #3

http://codereview.chromium.org/6758014/diff/1001/printing/printing_context.cc
File printing/printing_context.cc (right):

http://codereview.chromium.org/6758014/diff/1001/printing/printing_context.cc...
printing/printing_context.cc:37: ret &= (settings.GetBoolean(kSettingLandscape,
landscape));
On 2011/03/30 22:12:00, Lei Zhang wrote:
> nit: you probably don't need to outer parenthesis, in the same way you
wouldn't
> want to write:
> 
> foo = (bar.get());

Done.

Expand Messages | Collapse Messages