printing/printing_context_cairo.cc - Issue 6758014: PrintPreview: Added a helper function to get print job settings from dictionary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/printing_context_cairo.cc

Issue 6758014: PrintPreview: Added a helper function to get print job settings from dictionary. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix mac build error. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: printing/printing_context_cairo.cc

diff --git a/printing/printing_context_cairo.cc b/printing/printing_context_cairo.cc

index c721e3d1352c315adc995e8562042405737dee74..17e78850a46e5208326bae46f3433f441f5f4ec5 100644

--- a/printing/printing_context_cairo.cc

+++ b/printing/printing_context_cairo.cc

@@ -6,7 +6,6 @@

#include "base/logging.h"

#include "base/values.h"

-#include "printing/print_job_constants.h"

#include "printing/print_settings_initializer_gtk.h"

#include "printing/units.h"

@@ -154,10 +153,10 @@ PrintingContext::Result PrintingContextCairo::UpdatePrintSettings(

DCHECK(!in_print_job_);

bool landscape;

- if (!job_settings.GetBoolean(kSettingLandscape, &landscape))

+ if (!GetSettingsFromDict(job_settings, &landscape, NULL))

return OnError();

- settings_.SetOrientation(landscape);

+ settings_.SetOrientation(landscape);

settings_.ranges = ranges;

// TODO(kmadhusu): Update other print settings such as number of copies,

« no previous file with comments | « printing/printing_context.cc ('k') | printing/printing_context_mac.mm » ('j') | no next file with comments »