content/renderer/render_view_browsertest.cc - Issue 6750018: Cleanup: Stop creating RenderViewObservers from chrome/ in RenderViewer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 6750018: Cleanup: Stop creating RenderViewObservers from chrome/ in RenderViewer. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_browsertest.cc

===================================================================

--- content/renderer/render_view_browsertest.cc (revision 80410)

+++ content/renderer/render_view_browsertest.cc (working copy)

@@ -400,7 +400,7 @@

TEST_F(RenderViewTest, OnPrintPages) {

// Lets simulate a print pages with Hello world.

LoadHTML("<body><p>Hello World!</p></body>");

- view_->print_helper_->OnPrintPages();

+ PrintWebViewHelper::Get(view_)->OnPrintPages();

VerifyPageCount(1);

VerifyPagesPrinted(true);

@@ -432,7 +432,7 @@

VerifyPagesPrinted(false);

// Unblock script initiated printing and verify printing works.

- view_->print_helper_->ResetScriptedPrintCount();

+ PrintWebViewHelper::Get(view_)->ResetScriptedPrintCount();

render_thread_.printer()->ResetPrinter();

LoadHTML(kPrintWithJSHTML);

VerifyPageCount(1);

@@ -466,7 +466,7 @@

view_->webview()->mainFrame());

// Initiate printing.

- view_->print_helper_->OnPrintPages();

+ PrintWebViewHelper::Get(view_)->OnPrintPages();

// Verify output through MockPrinter.

const MockPrinter* printer(render_thread_.printer());

@@ -530,7 +530,7 @@

for (size_t i = 0; i < arraysize(kTestPages); ++i) {

// Load an HTML page and print it.

LoadHTML(kTestPages[i].page);

- view_->print_helper_->OnPrintPages();

+ PrintWebViewHelper::Get(view_)->OnPrintPages();

// MockRenderThread::Send() just calls MockRenderThread::OnMsgReceived().

// So, all IPC messages sent in the above RenderView::OnPrintPages() call