Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1422)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/renderer/render_view_observer.h

Issue 6750018: Cleanup: Stop creating RenderViewObservers from chrome/ in RenderViewer. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | content/renderer/render_view_observer_tracker.h » ('j') | content/renderer/render_view_observer_tracker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_observer.h
===================================================================
--- content/renderer/render_view_observer.h (revision 80410)
+++ content/renderer/render_view_observer.h (working copy)
@@ -45,6 +45,7 @@
const WebKit::WebFormElement& form) {}
virtual void DidCreateDataSource(WebKit::WebFrame* frame,
WebKit::WebDataSource* ds) {}
+ virtual void printPage(WebKit::WebFrame* frame) {}
jam 2011/04/05 18:10:07 this needs to be PrintPage (i.e. chromium style in
Lei Zhang 2011/04/05 21:03:16 Done.
// These match the RenderView methods below.
virtual void FrameTranslated(WebKit::WebFrame* frame) {}
@@ -53,7 +54,7 @@
bool preliminary_capture) {}
protected:
- RenderViewObserver(RenderView* render_view);
+ explicit RenderViewObserver(RenderView* render_view);
virtual ~RenderViewObserver();
// IPC::Channel::Listener implementation.
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | content/renderer/render_view_observer_tracker.h » ('j') | content/renderer/render_view_observer_tracker.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698