Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1640)

Unified Diff: content/renderer/render_view.h

Issue 6750018: Cleanup: Stop creating RenderViewObservers from chrome/ in RenderViewer. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view.h
===================================================================
--- content/renderer/render_view.h (revision 80410)
+++ content/renderer/render_view.h (working copy)
@@ -54,10 +54,7 @@
#endif
class AudioMessageFilter;
-class BlockedPlugin;
class DeviceOrientationDispatcher;
-class DevToolsAgent;
-class DevToolsClient;
class DomAutomationController;
class ExternalHostBindings;
class ExternalPopupMenu;
@@ -72,7 +69,6 @@
class PrintWebViewHelper;
class RenderViewObserver;
class RenderViewVisitor;
-class SearchBox;
class SkBitmap;
class SpeechInputDispatcher;
class SpellCheckProvider;
@@ -244,8 +240,6 @@
disable_scrollbars_size_limit_.height() <= height));
}
- SearchBox* searchbox() const { return searchbox_; }
-
const WebKit::WebNode& context_menu_node() { return context_menu_node_; }
// Current P2PSocketDispatcher. Set to NULL if P2P API is disabled.
@@ -638,7 +632,6 @@
FRIEND_TEST_ALL_PREFIXES(ExternalPopupMenuRemoveTest, RemoveOnChange);
FRIEND_TEST_ALL_PREFIXES(ExternalPopupMenuTest, NormalCase);
FRIEND_TEST_ALL_PREFIXES(ExternalPopupMenuTest, ShowPopupThenNavigate);
- FRIEND_TEST_ALL_PREFIXES(RenderViewTest, BlockScriptInitiatedPrinting);
FRIEND_TEST_ALL_PREFIXES(RenderViewTest, ImeComposition);
FRIEND_TEST_ALL_PREFIXES(RenderViewTest, InsertCharacters);
FRIEND_TEST_ALL_PREFIXES(RenderViewTest, JSBlockSentAfterPageLoad);
@@ -646,10 +639,7 @@
FRIEND_TEST_ALL_PREFIXES(RenderViewTest, OnHandleKeyboardEvent);
FRIEND_TEST_ALL_PREFIXES(RenderViewTest, OnImeStateChanged);
FRIEND_TEST_ALL_PREFIXES(RenderViewTest, OnNavStateChanged);
- FRIEND_TEST_ALL_PREFIXES(RenderViewTest, OnPrintPages);
FRIEND_TEST_ALL_PREFIXES(RenderViewTest, OnSetTextDirection);
- FRIEND_TEST_ALL_PREFIXES(RenderViewTest, PrintLayoutTest);
- FRIEND_TEST_ALL_PREFIXES(RenderViewTest, PrintWithIframe);
FRIEND_TEST_ALL_PREFIXES(RenderViewTest, UpdateTargetURLWithInvalidURL);
#if defined(OS_MACOSX)
FRIEND_TEST_ALL_PREFIXES(RenderViewTest, MacTestCmdUp);
@@ -1237,11 +1227,6 @@
// Device orientation dispatcher attached to this view; lazily initialized.
DeviceOrientationDispatcher* device_orientation_dispatcher_;
- // PrintWebViewHelper handles printing
- PrintWebViewHelper* print_helper_;
-
- SearchBox* searchbox_;
-
// spellcheck provider which is registered as a view observer.
SpellCheckProvider* spellcheck_provider_;

Powered by Google App Engine
This is Rietveld 408576698