Issue 6749014: Workground for glGenerateMipmap bug in some drivers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6749014: Workground for glGenerateMipmap bug in some drivers. (Closed)

Created:
9 years, 9 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
Zhenyao Mo, apatrick_chromium

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Workground for glGenerateMipmap bug in some drivers. TEST=unit tests BUG=72601 R=zmo@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79499

Patch Set 2 : comment change #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -2 lines)			Patch
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc	View		2 chunks	+12 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager.h	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager_unittest.cc	View		2 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

LGTM http://codereview.chromium.org/6749014/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): http://codereview.chromium.org/6749014/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode2859 gpu/command_buffer/service/gles2_cmd_decoder.cc:2859: // Workaround for Mac driver bug. Since glGenerateMipmap ...

9 years, 9 months ago (2011-03-25 21:53:26 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 6749014: Workground for glGenerateMipmap bug in some drivers. (Closed)

Description

Patch Set 1 #

Patch Set 2 : comment change #

Messages