Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: gpu/command_buffer/service/texture_manager_unittest.cc

Issue 6749014: Workground for glGenerateMipmap bug in some drivers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment change Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/texture_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/texture_manager_unittest.cc
diff --git a/gpu/command_buffer/service/texture_manager_unittest.cc b/gpu/command_buffer/service/texture_manager_unittest.cc
index 0b59fc557328fbac4b01ef5371990b3c98a20754..7fab5d3a0882f6130ce832768121d1a31ee27fb6 100644
--- a/gpu/command_buffer/service/texture_manager_unittest.cc
+++ b/gpu/command_buffer/service/texture_manager_unittest.cc
@@ -93,6 +93,29 @@ TEST_F(TextureManagerTest, Basic) {
EXPECT_TRUE(manager_.GetTextureInfo(kClient1Id) == NULL);
}
+TEST_F(TextureManagerTest, SetParameter) {
+ const GLuint kClient1Id = 1;
+ const GLuint kService1Id = 11;
+ EXPECT_FALSE(manager_.HaveUnrenderableTextures());
+ // Check we can create texture.
+ manager_.CreateTextureInfo(&feature_info_, kClient1Id, kService1Id);
+ // Check texture got created.
+ TextureManager::TextureInfo* info = manager_.GetTextureInfo(kClient1Id);
+ ASSERT_TRUE(info != NULL);
+ manager_.SetParameter(
+ &feature_info_, info, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
+ EXPECT_EQ(static_cast<GLenum>(GL_NEAREST), info->min_filter());
+ manager_.SetParameter(
+ &feature_info_, info, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
+ EXPECT_EQ(static_cast<GLenum>(GL_NEAREST), info->mag_filter());
+ manager_.SetParameter(
+ &feature_info_, info, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
+ EXPECT_EQ(static_cast<GLenum>(GL_CLAMP_TO_EDGE), info->wrap_s());
+ manager_.SetParameter(
+ &feature_info_, info, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
+ EXPECT_EQ(static_cast<GLenum>(GL_CLAMP_TO_EDGE), info->wrap_t());
+}
+
TEST_F(TextureManagerTest, Destroy) {
const GLuint kClient1Id = 1;
const GLuint kService1Id = 11;
@@ -263,6 +286,10 @@ TEST_F(TextureInfoTest, Basic) {
EXPECT_FALSE(info_->CanGenerateMipmaps(&feature_info_));
EXPECT_FALSE(info_->npot());
EXPECT_FALSE(info_->CanRender(&feature_info_));
+ EXPECT_EQ(static_cast<GLenum>(GL_NEAREST_MIPMAP_LINEAR), info_->min_filter());
+ EXPECT_EQ(static_cast<GLenum>(GL_LINEAR), info_->mag_filter());
+ EXPECT_EQ(static_cast<GLenum>(GL_REPEAT), info_->wrap_s());
+ EXPECT_EQ(static_cast<GLenum>(GL_REPEAT), info_->wrap_t());
EXPECT_TRUE(manager_.HaveUnrenderableTextures());
}
« no previous file with comments | « gpu/command_buffer/service/texture_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698