Issue 6748013: Modifying the test, popups.PopupsTest.testLaunchBlockedPopupInIncognito, to wait until popup is b...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6748013: Modifying the test, popups.PopupsTest.testLaunchBlockedPopupInIncognito, to wait until popup is b... (Closed)

Created:
9 years, 9 months ago by sunandt

Modified:
9 years, 7 months ago

Reviewers:
anantha

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/test/

Visibility:
Public.

Description

Modifying the test, popups.PopupsTest.testLaunchBlockedPopupInIncognito, to wait until popup is blocked. BUG=70659 TEST=Test should pass on pyauto bots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79596

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	functional/popups.py	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

anantha

Please add suggested change and check-in. LGTM. http://codereview.chromium.org/6748013/diff/1/functional/popups.py File functional/popups.py (right): http://codereview.chromium.org/6748013/diff/1/functional/popups.py#newcode70 functional/popups.py:70: len(self.GetBlockedPopupsInfo(tab_index=0, windex=1)), ...

9 years, 8 months ago (2011-03-28 18:41:30 UTC) #2

sunandt

9 years, 8 months ago (2011-03-28 18:56:46 UTC) #3

http://codereview.chromium.org/6748013/diff/1/functional/popups.py
File functional/popups.py (right):

http://codereview.chromium.org/6748013/diff/1/functional/popups.py#newcode70
functional/popups.py:70: len(self.GetBlockedPopupsInfo(tab_index=0, windex=1)),
expect_retval=1)
On 2011/03/28 18:41:30, anantha wrote:
> Please do self.assertEqual check again after self.WaitUntil :
>  self.assertEqual(1, len(self.GetBlockedPopupsInfo(tab_index=0, windex=1)))

Since WaitUntil returns either True or False, I'm using assertTrue, so we can
assert when Chrome fails to block the popup.

Expand Messages | Collapse Messages