Modifying the test, popups.PopupsTest.testLaunchBlockedPopupInIncognito, to wait until popup is b...

functional/popups.py

 #!/usr/bin/python
 
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 
 import pyauto_functional  # Must be imported before pyauto
 import pyauto
@@ skipping 47 matching lines @@
     self.NavigateToURL(file_url, 1, 0)
     blocked_popups = self.GetBlockedPopupsInfo(tab_index=0, windex=1)
     self.assertEqual(1, len(blocked_popups), msg='Popup not blocked')
 
   def testLaunchBlockedPopupInIncognito(self):
     """Verify that a blocked popup can be unblocked in incognito."""
     self.RunCommand(pyauto.IDC_NEW_INCOGNITO_WINDOW)
     file_url = self.GetFileURLForPath(os.path.join(
         self.DataDir(), 'popup_blocker', 'popup-window-open.html'))
     self.NavigateToURL(file_url, 1, 0)
-    self.assertEqual(1, len(self.GetBlockedPopupsInfo(tab_index=0, windex=1)))
+    # Wait until the popup is blocked
+    self.WaitUntil(lambda:
+        len(self.GetBlockedPopupsInfo(tab_index=0, windex=1)), expect_retval=1)

[anantha, 2011/03/28 18:41:30]

Please do self.assertEqual check again after self.WaitUntil :
 self.assertEqual(1, len(self.GetBlockedPopupsInfo(tab_index=0, windex=1)))

[sunandt, 2011/03/28 18:56:47]

Since WaitUntil returns either True or False, I'm using assertTrue, so we can
assert when Chrome fails to block the popup.

     self.UnblockAndLaunchBlockedPopup(0, tab_index=0, windex=1)
     # Verify that no more popups are blocked
     self.assertFalse(self.GetBlockedPopupsInfo(tab_index=0, windex=1))
     # Verify that popup window was created
     self.assertEqual(3, self.GetBrowserWindowCount(),
                      msg='Popup could not be launched');
     self.assertEqual('Popup Success!', self.GetActiveTabTitle(2))
 
 
 if __name__ == '__main__':
   pyauto_functional.Main()