base/base_api.h - Issue 6747014: Base: Last set of files to use BASE_API (for base.dll)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base_api.h

Issue 6747014: Base: Last set of files to use BASE_API (for base.dll) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/base_api.h

===================================================================

--- base/base_api.h (revision 79303)

+++ base/base_api.h (working copy)

@@ -6,16 +6,12 @@

#define BASE_BASE_API_H_

#pragma once

-#if !defined(BASE_IMPLEMENTATION)

-#define BASE_IMPLEMENTATION 0

-#endif

#if defined(WIN32) && defined(BASE_DLL)

-#if BASE_IMPLEMENTATION

+#if defined(BASE_IMPLEMENTATION)

#define BASE_API __declspec(dllexport)

#else

#define BASE_API __declspec(dllimport)

-#endif

+#endif // defined(BASE_IMPLEMENTATION)

wtc 2011/03/28 22:24:33 Nit: for short ifdef blocks, I would omit these co

rvargas (doing something else) 2011/03/28 22:36:23 Yes, I do too. But I think it adds clarity in this

#else

#define BASE_API

#endif

« no previous file with comments | « base/base.gypi ('k') | base/crypto/capi_util.h » ('j') | no next file with comments »