base/base_api.h - Issue 6747014: Base: Last set of files to use BASE_API (for base.dll)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/base_api.h

Issue 6747014: Base: Last set of files to use BASE_API (for base.dll) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef BASE_BASE_API_H_	5 #ifndef BASE_BASE_API_H_

6 #define BASE_BASE_API_H_	6 #define BASE_BASE_API_H_

7 #pragma once	7 #pragma once

8	8

9 #if !defined(BASE_IMPLEMENTATION)

10 #define BASE_IMPLEMENTATION 0

11 #endif

12

13 #if defined(WIN32) && defined(BASE_DLL)	9 #if defined(WIN32) && defined(BASE_DLL)

14 #if BASE_IMPLEMENTATION	10 #if defined(BASE_IMPLEMENTATION)

15 #define BASE_API __declspec(dllexport)	11 #define BASE_API __declspec(dllexport)

16 #else	12 #else

17 #define BASE_API __declspec(dllimport)	13 #define BASE_API __declspec(dllimport)

18 #endif	14 #endif // defined(BASE_IMPLEMENTATION)
	wtc 2011/03/28 22:24:33 Nit: for short ifdef blocks, I would omit these co Nit: for short ifdef blocks, I would omit these comments for endifs. rvargas (doing something else) 2011/03/28 22:36:23 Yes, I do too. But I think it adds clarity in this Show quoted text On 2011/03/28 22:24:33, wtc wrote: > Nit: for short ifdef blocks, I would omit these comments > for endifs. Yes, I do too. But I think it adds clarity in this case given the nesting. (and that's why I added only one comment)
19 #else	15 #else

20 #define BASE_API	16 #define BASE_API

21 #endif	17 #endif

22	18

23 #endif // BASE_BASE_API_H_	19 #endif // BASE_BASE_API_H_

OLD	NEW

« no previous file with comments | « base/base.gypi ('k') | base/crypto/capi_util.h » ('j') | no next file with comments »