Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 6747014: Base: Last set of files to use BASE_API (for base.dll) (Closed)

Created:
9 years, 9 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
Reviewers:
wtc
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Base: Last set of files to use BASE_API (for base.dll) Note that a bunck of these files have no unit tests :( BUG=76996 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79633

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -93 lines) Patch
base/base.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
base/base_api.h View 1 1 chunk +2 lines, -6 lines 0 comments Download
base/crypto/capi_util.h View 1 3 chunks +8 lines, -6 lines 0 comments Download
base/crypto/encryptor.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
base/crypto/rsa_private_key.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
base/crypto/secure_hash.h View 1 1 chunk +2 lines, -1 line 0 comments Download
base/crypto/signature_creator.h View 1 2 chunks +2 lines, -1 line 0 comments Download
base/crypto/signature_verifier.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
base/crypto/symmetric_key.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
base/debug/trace_event_win.h View 1 4 chunks +7 lines, -5 lines 0 comments Download
base/event_recorder.h View 1 2 chunks +3 lines, -1 line 0 comments Download
base/file_util_proxy.h View 1 2 chunks +2 lines, -1 line 0 comments Download
base/logging_win.h View 1 3 chunks +4 lines, -2 lines 0 comments Download
base/md5.h View 1 3 chunks +9 lines, -7 lines 0 comments Download
base/memory/memory_debug.h View 1 1 chunk +2 lines, -1 line 0 comments Download
base/memory/ref_counted_memory.h View 1 4 chunks +5 lines, -3 lines 0 comments Download
base/resource_util.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
base/sync_socket.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
base/synchronization/cancellation_flag.h View 1 2 chunks +2 lines, -1 line 0 comments Download
base/synchronization/condition_variable.h View 1 2 chunks +2 lines, -1 line 0 comments Download
base/synchronization/waitable_event_watcher.h View 1 2 chunks +3 lines, -1 line 0 comments Download
base/threading/non_thread_safe.h View 1 1 chunk +1 line, -1 line 0 comments Download
base/threading/thread_checker_impl.h View 1 2 chunks +2 lines, -1 line 0 comments Download
base/threading/thread_collision_warner.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
base/threading/thread_local.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
base/threading/watchdog.h View 1 2 chunks +2 lines, -1 line 0 comments Download
base/threading/worker_pool.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
base/value_conversions.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
base/win/event_trace_controller.h View 1 4 chunks +5 lines, -3 lines 0 comments Download
base/win/event_trace_provider.h View 1 3 chunks +4 lines, -2 lines 0 comments Download
base/win/i18n.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
base/win/object_watcher.h View 1 2 chunks +2 lines, -1 line 0 comments Download
base/win/registry.h View 1 4 chunks +4 lines, -3 lines 0 comments Download
base/win/scoped_bstr.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
base/win/scoped_variant.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
base/win/win_util.h View 1 3 chunks +15 lines, -14 lines 0 comments Download
base/win/wrapped_window_proc.h View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rvargas (doing something else)
9 years, 9 months ago (2011-03-25 22:14:56 UTC) #1
wtc
LGTM. http://codereview.chromium.org/6747014/diff/1/base/base_api.h File base/base_api.h (right): http://codereview.chromium.org/6747014/diff/1/base/base_api.h#newcode14 base/base_api.h:14: #endif // defined(BASE_IMPLEMENTATION) Nit: for short ifdef blocks, ...
9 years, 9 months ago (2011-03-28 22:24:33 UTC) #2
rvargas (doing something else)
9 years, 9 months ago (2011-03-28 22:36:23 UTC) #3
Thanks

http://codereview.chromium.org/6747014/diff/1/base/base_api.h
File base/base_api.h (right):

http://codereview.chromium.org/6747014/diff/1/base/base_api.h#newcode14
base/base_api.h:14: #endif  // defined(BASE_IMPLEMENTATION)
On 2011/03/28 22:24:33, wtc wrote:
> Nit: for short ifdef blocks, I would omit these comments
> for endifs.

Yes, I do too. But I think it adds clarity in this case given the nesting. (and
that's why I added only one comment)

Powered by Google App Engine
This is Rietveld 408576698