printing/printing_context_cairo.cc - Issue 6747003: PrintPreview: Remove NOTIMPLEMENTED() function call in PrintingContextCairo::UpdatePrintSettings().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/printing_context_cairo.cc

Issue 6747003: PrintPreview: Remove NOTIMPLEMENTED() function call in PrintingContextCairo::UpdatePrintSettings(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: printing/printing_context_cairo.cc

diff --git a/printing/printing_context_cairo.cc b/printing/printing_context_cairo.cc

index 75dac3e4219aa0c3057049138e1c408cf600bb9b..5687fff5a838f9c0a1806b2b70398ce16a276a29 100644

--- a/printing/printing_context_cairo.cc

+++ b/printing/printing_context_cairo.cc

@@ -154,9 +154,10 @@ PrintingContext::Result PrintingContextCairo::UpdatePrintSettings(

settings_.ranges = ranges;

- NOTIMPLEMENTED();

+ // TODO(kmadhusu): Update other print settings such as number of copies,

+ // collate, duplex printing, etc.,

- return FAILED;

+ return OK;

}

PrintingContext::Result PrintingContextCairo::InitWithSettings(

« no previous file with comments | « no previous file | no next file » | no next file with comments »