Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: printing/printing_context_cairo.cc

Issue 6747003: PrintPreview: Remove NOTIMPLEMENTED() function call in PrintingContextCairo::UpdatePrintSettings(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "printing/printing_context_cairo.h" 5 #include "printing/printing_context_cairo.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "printing/units.h" 9 #include "printing/units.h"
10 #include "printing/print_settings_initializer_gtk.h" 10 #include "printing/print_settings_initializer_gtk.h"
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 147
148 return OK; 148 return OK;
149 } 149 }
150 150
151 PrintingContext::Result PrintingContextCairo::UpdatePrintSettings( 151 PrintingContext::Result PrintingContextCairo::UpdatePrintSettings(
152 const DictionaryValue& job_settings, const PageRanges& ranges) { 152 const DictionaryValue& job_settings, const PageRanges& ranges) {
153 DCHECK(!in_print_job_); 153 DCHECK(!in_print_job_);
154 154
155 settings_.ranges = ranges; 155 settings_.ranges = ranges;
156 156
157 NOTIMPLEMENTED(); 157 // TODO(kmadhusu): Update other print settings such as number of copies,
158 // collate, duplex printing, etc.,
158 159
159 return FAILED; 160 return OK;
160 } 161 }
161 162
162 PrintingContext::Result PrintingContextCairo::InitWithSettings( 163 PrintingContext::Result PrintingContextCairo::InitWithSettings(
163 const PrintSettings& settings) { 164 const PrintSettings& settings) {
164 DCHECK(!in_print_job_); 165 DCHECK(!in_print_job_);
165 166
166 settings_ = settings; 167 settings_ = settings;
167 168
168 return OK; 169 return OK;
169 } 170 }
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 void PrintingContextCairo::ReleaseContext() { 218 void PrintingContextCairo::ReleaseContext() {
218 // Intentional No-op. 219 // Intentional No-op.
219 } 220 }
220 221
221 gfx::NativeDrawingContext PrintingContextCairo::context() const { 222 gfx::NativeDrawingContext PrintingContextCairo::context() const {
222 // Intentional No-op. 223 // Intentional No-op.
223 return NULL; 224 return NULL;
224 } 225 }
225 226
226 } // namespace printing 227 } // namespace printing
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698