Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 6736025: autotest/factory: improve message feedback on UI (Closed)

Created:
9 years, 9 months ago by Hung-Te
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli
Visibility:
Public.

Description

autotest/factory: improve message feedback on UI This CL improved factory UI message feedback by: - allowing gooftool output goes to console immediately - provides hardware components matching results on Review screen This CL needs to be applied with http://codereview.chromium.org/6733063 . BUG=chromium-os:13459 TEST=Running hardware_Components on UI. The probing verbose message now displayed progress immediately. For "unmatched" results, the review page will list the difference. Sample: TestFail: No HWID matched. Unmatched for XXX: {'hash_ec_firmware': ['644f95ee34c79ebf833c3f6002325b33506ecf18449e9b2c574e519a2e573e6e'], 'key_recovery': ['No match'], 'key_root': ['No match'], 'part_id_3g': ['No match'],} Unmatched for YYY: {'part_id_3g': ['No match'], 'part_id_audio_codec': ['Realtek ALC271X'], 'part_id_cpu': ['Intel(R) Atom(TM) CPU N570 @ 1.66GHz'], 'part_id_ec_flash_chip': ['Winbond W25x40']} Change-Id: Ie63c327a114e82f17b0601f8748f015b9be9f32c R=tammo@chromium.org,nsanders@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=73511ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -63 lines) Patch
M client/bin/factory.py View 1 chunk +2 lines, -1 line 0 comments Download
M client/bin/factory_ui View 1 chunk +2 lines, -2 lines 0 comments Download
M client/cros/gooftools.py View 1 chunk +40 lines, -24 lines 0 comments Download
M client/site_tests/factory_Finalize/factory_Finalize.py View 1 chunk +0 lines, -1 line 0 comments Download
M client/site_tests/factory_PreFinalCheck/factory_PreFinalCheck.py View 2 chunks +2 lines, -2 lines 0 comments Download
M client/site_tests/factory_WriteGBB/factory_WriteGBB.py View 1 chunk +5 lines, -2 lines 0 comments Download
M client/site_tests/hardware_Components/hardware_Components.py View 2 chunks +56 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Hung-Te
9 years, 9 months ago (2011-03-25 12:07:40 UTC) #1
Hung-Te
Any feedbacks?
9 years, 8 months ago (2011-03-30 03:04:37 UTC) #2
Nick Sanders
9 years, 8 months ago (2011-03-31 06:57:34 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698