factory_test_init: split output into verbose log and console data

factory_test_init: split output into verbose log and console data

To support subshell execution (ex, gooftool) in a better way,
we should separate "log" and "console info".

This CL makes everything from autotest goes to factory.log, while lines with
"FACTORY" also goes to console for feedback to operators.

This CL must be applied with http://codereview.chromium.org/6736025/.

BUG=chromium-os:13459
TEST=build a factory image and install;
     seeing messages appears in console window.

Change-Id: Ib37250484eeb99e30a5ca29d254f69d7d84594e6

R=tammo@chromium.org,nsanders@chromium.org

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a52b466

[Hung-Te, 2011-03-30 03:04:57]

Any feedback?

[jrbarnette, 2011-03-30 18:14:39]

LGTM, FWIW, but I have a question that could prompt code
changes.

http://codereview.chromium.org/6733063/diff/1/factory.conf
File factory.conf (right):

http://codereview.chromium.org/6733063/diff/1/factory.conf#newcode32
factory.conf:32: grep --line-buffer "FACTORY" >>"$CONSOLE_LOG_FILE"
Are you sure the pattern "FACTORY" is restrictive enough?  I'm
assuming that the string FACTORY is a prefix on the line, but
this pattern will match any line that includes FACTORY, even if
it isn't a prefix.

[Nick Sanders, 2011-03-30 18:28:52]

lgtm

[Hung-Te, 2011-03-31 02:17:10]

http://codereview.chromium.org/6733063/diff/1/factory.conf
File factory.conf (right):

http://codereview.chromium.org/6733063/diff/1/factory.conf#newcode32
factory.conf:32: grep --line-buffer "FACTORY" >>"$CONSOLE_LOG_FILE"
On 2011/03/30 18:14:40, jrbarnette wrote:
> Are you sure the pattern "FACTORY" is restrictive enough?  
> this pattern will match any line that includes FACTORY, even if
> it isn't a prefix.
  
 A sample of the data format:
01:21:28 ERROR| FACTORY: factory_ui setup done, starting gtk.main()...

 However since this is simply for "showing data on console (for operator to get
some visual feedback)", I think more is better than less.