Base: A few more files using BASE_API (for base.dll)

base/debug/debug_on_start_win.h

Index: base/debug/debug_on_start_win.h
===================================================================
--- base/debug/debug_on_start_win.h	(revision 79303)
+++ base/debug/debug_on_start_win.h	(working copy)
@@ -10,6 +10,7 @@
 #define BASE_DEBUG_DEBUG_ON_START_WIN_H_
 #pragma once
 
+#include "base/base_api.h"

[wtc, 2011/03/25 17:20:34]

Does this file need to include base_api.h?  It doesn't use
the BASE_API macro.

[rvargas (doing something else), 2011/03/25 17:43:00]

This is a good point. Happy to remove it.

 #include "base/basictypes.h"
 #include "build/build_config.h"
 
@@ -24,6 +25,8 @@
 namespace base {
 namespace debug {
 
+#if !defined(BASE_DLL)

[wtc, 2011/03/25 17:20:34]

It would be nice to add a comment to explain why this file
should not be included if base is built as a DLL.

[rvargas (doing something else), 2011/03/25 17:43:00]

I'm tempted to rip this code altogether :)

Added:

// There is no way for this code, as currently implemented, to work across DLLs.
// TODO(rvargas): It looks like we really don't use this code, at least not for
// Chrome. Figure out if it's really worth implementing something simpler.

+
 // Debug on start functions and data.
 class DebugOnStart {
  public:
@@ -69,6 +72,8 @@
 
 #endif  // _WIN64
 
+#endif  // defined(BASE_DLL)
+
 }  // namespace debug
 }  // namespace base