Base: A few more files using BASE_API (for base.dll)

base/debug/debug_on_start_win.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Define the necessary code and global data to look for kDebugOnStart command
 // line argument. When the command line argument is detected, it invokes the
 // debugger, if no system-wide debugger is registered, a debug break is done.
 
 #ifndef BASE_DEBUG_DEBUG_ON_START_WIN_H_
 #define BASE_DEBUG_DEBUG_ON_START_WIN_H_
 #pragma once
 
+#include "base/base_api.h"

[wtc, 2011/03/25 17:20:34]

Does this file need to include base_api.h?  It doesn't use
the BASE_API macro.

[rvargas (doing something else), 2011/03/25 17:43:00]

This is a good point. Happy to remove it.

 #include "base/basictypes.h"
 #include "build/build_config.h"
 
 // This only works on Windows. It's legal to include on other platforms, but
 // will be a NOP.
 #if defined(OS_WIN)
 
 #ifndef DECLSPEC_SELECTANY
 #define DECLSPEC_SELECTANY  __declspec(selectany)
 #endif
 
 namespace base {
 namespace debug {
 
+#if !defined(BASE_DLL)

[wtc, 2011/03/25 17:20:34]

It would be nice to add a comment to explain why this file
should not be included if base is built as a DLL.

[rvargas (doing something else), 2011/03/25 17:43:00]

I'm tempted to rip this code altogether :)

Added:

// There is no way for this code, as currently implemented, to work across DLLs.
// TODO(rvargas): It looks like we really don't use this code, at least not for
// Chrome. Figure out if it's really worth implementing something simpler.

+
 // Debug on start functions and data.
 class DebugOnStart {
  public:
   // Expected function type in the .CRT$XI* section.
   // Note: See VC\crt\src\internal.h for reference.
   typedef int  (__cdecl *PIFV)(void);
 
   // Looks at the command line for kDebugOnStart argument. If found, it invokes
   // the debugger, if this fails, it crashes.
   static int __cdecl Init();
@@ skipping 25 matching lines @@
 // "Fix" the segment. On x86, the .CRT segment is merged into the .data segment
 // so it contains non-const data only.
 #pragma data_seg(push, ".CRT$XIB")
 // Declare the pointer so the CRT will find it.
 DECLSPEC_SELECTANY DebugOnStart::PIFV debug_on_start = &DebugOnStart::Init;
 // Fix back the segment.
 #pragma data_seg(pop)
 
 #endif  // _WIN64
 
+#endif  // defined(BASE_DLL)
+
 }  // namespace debug
 }  // namespace base
 
 #endif  // defined(OS_WIN)
 
 #endif  // BASE_DEBUG_DEBUG_ON_START_WIN_H_