Issue 6736019: Base: A few more files using BASE_API (for base.dll)

Issue 6736019: Base: A few more files using BASE_API (for base.dll) (Closed)

Created:
9 years, 9 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
wtc

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Base: A few more files using BASE_API (for base.dll) BUG=76996 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79427

Patch Set 2 : '' #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -121 lines)			Patch
M	base/debug/debug_on_start_win.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	base/debug/debugger.h	View		3 chunks	+9 lines, -7 lines	0 comments	Download
M	base/debug/stack_trace.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	base/message_loop.h	View		7 chunks	+7 lines, -5 lines	0 comments	Download
M	base/message_loop_proxy.h	View		4 chunks	+4 lines, -2 lines	0 comments	Download
M	base/message_loop_proxy_impl.h	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	base/message_pump.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	base/message_pump_win.h	View		4 chunks	+4 lines, -3 lines	0 comments	Download
M	base/metrics/histogram.h	View		7 chunks	+7 lines, -6 lines	0 comments	Download
M	base/metrics/stats_counters.h	View		5 chunks	+5 lines, -4 lines	0 comments	Download
M	base/metrics/stats_table.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	base/native_library.h	View		4 chunks	+9 lines, -7 lines	0 comments	Download
M	base/process.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	base/process_util.h	View		15 chunks	+58 lines, -53 lines	0 comments	Download
M	base/scoped_native_library.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	base/sys_info.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	base/threading/thread.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	base/timer.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	base/tracked_objects.h	View		9 chunks	+9 lines, -8 lines	0 comments	Download
M	base/vlog.h	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	base/weak_ptr.h	View		5 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. http://codereview.chromium.org/6736019/diff/1/base/debug/debug_on_start_win.h File base/debug/debug_on_start_win.h (right): http://codereview.chromium.org/6736019/diff/1/base/debug/debug_on_start_win.h#newcode13 base/debug/debug_on_start_win.h:13: #include "base/base_api.h" Does this file need to include ...

9 years, 9 months ago (2011-03-25 17:20:34 UTC) #2

rvargas (doing something else)

9 years, 9 months ago (2011-03-25 17:43:00 UTC) #3

Thanks.

http://codereview.chromium.org/6736019/diff/1/base/debug/debug_on_start_win.h
File base/debug/debug_on_start_win.h (right):

http://codereview.chromium.org/6736019/diff/1/base/debug/debug_on_start_win.h...
base/debug/debug_on_start_win.h:13: #include "base/base_api.h"
On 2011/03/25 17:20:34, wtc wrote:
> Does this file need to include base_api.h?  It doesn't use
> the BASE_API macro.

This is a good point. Happy to remove it.

http://codereview.chromium.org/6736019/diff/1/base/debug/debug_on_start_win.h...
base/debug/debug_on_start_win.h:28: #if !defined(BASE_DLL)
On 2011/03/25 17:20:34, wtc wrote:
> It would be nice to add a comment to explain why this file
> should not be included if base is built as a DLL.

I'm tempted to rip this code altogether :)

Added:

// There is no way for this code, as currently implemented, to work across DLLs.
// TODO(rvargas): It looks like we really don't use this code, at least not for
// Chrome. Figure out if it's really worth implementing something simpler.

Expand Messages | Collapse Messages