Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: presubmit_canned_checks.py

Issue 6736018: improve logging slightly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: fix baseline of patchset Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl/git_cl.py ('k') | presubmit_support.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index 2adc371a8c725c75f9030ee6d56e8645072f7a99..2a868a57548fc8fcb3876e16870cccee669ae943 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -631,10 +631,12 @@ def CheckOwners(input_api, output_api, source_file_filter=None):
if not input_api.is_committing:
return []
if input_api.tbr:
- return [output_api.PresubmitNotifyResult('--tbr was specified, '
- 'skipping OWNERS check')]
+ return [output_api.PresubmitNotifyResult(
+ '--tbr was specified, skipping OWNERS check')]
if not input_api.change.issue:
- return [output_api.PresubmitError('Change not uploaded for review')]
+ return [output_api.PresubmitError(
+ "OWNERS check failed: this change has no Rietveld issue number, so "
+ "we can't check it for approvals.")]
affected_files = set([f.LocalPath() for f in
input_api.change.AffectedFiles(source_file_filter)])
« no previous file with comments | « git_cl/git_cl.py ('k') | presubmit_support.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698