git_cl/git_cl.py - Issue 6736018: improve logging slightly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl/git_cl.py

Issue 6736018: improve logging slightly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: fix baseline of patchset Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: git_cl/git_cl.py

diff --git a/git_cl/git_cl.py b/git_cl/git_cl.py

index 218c9f3dae502f739951780173f5b41f56964fea..665e2a0c5646d10c53801c80a8e5053b0f1b2983 100644

--- a/git_cl/git_cl.py

+++ b/git_cl/git_cl.py

@@ -840,18 +840,10 @@ def CMDpresubmit(parser, args):

# Default to diffing against the "upstream" branch.

base_branch = cl.GetUpstreamBranch()

- if options.upload:

- print '*** Presubmit checks for UPLOAD would report: ***'

- RunHook(committing=False, upstream_branch=base_branch,

- rietveld_server=cl.GetRietveldServer(), tbr=False,

- may_prompt=False)

- return 0

- else:

- print '*** Presubmit checks for DCOMMIT would report: ***'

- RunHook(committing=True, upstream_branch=base_branch,

- rietveld_server=cl.GetRietveldServer, tbr=False,

- may_prompt=False)

- return 0

+ RunHook(committing=not options.upload, upstream_branch=base_branch,

+ rietveld_server=cl.GetRietveldServer(), tbr=False,

+ may_prompt=False)

+ return 0

@usage('[args to "git diff"]')

« no previous file with comments | « no previous file | presubmit_canned_checks.py » ('j') | no next file with comments »