Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6735042: Move favicon from TabContents to TabContentsWrapper. (Closed)

Created:
9 years, 8 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Move favicon from TabContents to TabContentsWrapper. BUG=71097 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80519

Patch Set 1 #

Patch Set 2 : quick win fix #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -750 lines) Patch
M chrome/browser/aeropeek_manager.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/wm_overview_controller.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/content_setting_bubble_model.cc View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/browser/favicon_helper.h View 1 chunk +0 lines, -185 lines 0 comments Download
D chrome/browser/favicon_helper.cc View 1 chunk +0 lines, -315 lines 0 comments Download
A + chrome/browser/favicon_tab_helper.h View 5 chunks +33 lines, -16 lines 0 comments Download
A + chrome/browser/favicon_tab_helper.cc View 16 chunks +124 lines, -41 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 8 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc View 4 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/web_applications/web_app_ui.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 2 8 chunks +4 lines, -32 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 6 chunks +2 lines, -78 lines 0 comments Download
M content/browser/tab_contents/tab_contents_observer.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents_observer.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/webui/web_ui_unittest.cc View 1 2 10 chunks +19 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
9 years, 8 months ago (2011-04-05 18:22:53 UTC) #1
jam
9 years, 8 months ago (2011-04-05 19:42:52 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698