Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/browser/ui/tab_contents/tab_contents_wrapper.h

Issue 6735042: Move favicon from TabContents to TabContentsWrapper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_ 5 #ifndef CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_
6 #define CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_ 6 #define CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 12 matching lines...) Expand all
23 class PrintPreviewMessageHandler; 23 class PrintPreviewMessageHandler;
24 class PrintViewManager; 24 class PrintViewManager;
25 } 25 }
26 26
27 class AutocompleteHistoryManager; 27 class AutocompleteHistoryManager;
28 class AutofillManager; 28 class AutofillManager;
29 class DevToolsObserver; 29 class DevToolsObserver;
30 class Extension; 30 class Extension;
31 class ExtensionMessageObserver; 31 class ExtensionMessageObserver;
32 class ExtensionTabHelper; 32 class ExtensionTabHelper;
33 class FaviconTabHelper;
33 class FileSelectObserver; 34 class FileSelectObserver;
34 class FindTabHelper; 35 class FindTabHelper;
35 class NavigationController; 36 class NavigationController;
36 class PasswordManager; 37 class PasswordManager;
37 class PasswordManagerDelegate; 38 class PasswordManagerDelegate;
38 class SearchEngineTabHelper; 39 class SearchEngineTabHelper;
39 class TabContentsWrapperDelegate; 40 class TabContentsWrapperDelegate;
40 41
41 // Wraps TabContents and all of its supporting objects in order to control 42 // Wraps TabContents and all of its supporting objects in order to control
42 // their ownership and lifetime, while allowing TabContents to remain generic 43 // their ownership and lifetime, while allowing TabContents to remain generic
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 AutocompleteHistoryManager* autocomplete_history_manager() { 97 AutocompleteHistoryManager* autocomplete_history_manager() {
97 return autocomplete_history_manager_.get(); 98 return autocomplete_history_manager_.get();
98 } 99 }
99 100
100 AutofillManager* autofill_manager() { return autofill_manager_.get(); } 101 AutofillManager* autofill_manager() { return autofill_manager_.get(); }
101 102
102 ExtensionTabHelper* extension_tab_helper() { 103 ExtensionTabHelper* extension_tab_helper() {
103 return extension_tab_helper_.get(); 104 return extension_tab_helper_.get();
104 } 105 }
105 106
107 FaviconTabHelper* favicon_tab_helper() { return favicon_tab_helper_.get(); }
108
106 FindTabHelper* find_tab_helper() { return find_tab_helper_.get(); } 109 FindTabHelper* find_tab_helper() { return find_tab_helper_.get(); }
107 110
108 PasswordManager* password_manager() { return password_manager_.get(); } 111 PasswordManager* password_manager() { return password_manager_.get(); }
109 112
110 SearchEngineTabHelper* search_engine_tab_helper() { 113 SearchEngineTabHelper* search_engine_tab_helper() {
111 return search_engine_tab_helper_.get(); 114 return search_engine_tab_helper_.get();
112 } 115 }
113 116
114 // Overrides ----------------------------------------------------------------- 117 // Overrides -----------------------------------------------------------------
115 118
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 scoped_ptr<printing::PrintViewManager> printing_; 160 scoped_ptr<printing::PrintViewManager> printing_;
158 161
159 // Handles Print Preview messages. 162 // Handles Print Preview messages.
160 scoped_ptr<printing::PrintPreviewMessageHandler> print_preview_; 163 scoped_ptr<printing::PrintPreviewMessageHandler> print_preview_;
161 164
162 // Tab Helpers --------------------------------------------------------------- 165 // Tab Helpers ---------------------------------------------------------------
163 // (These provide API for callers and have a getter function listed in the 166 // (These provide API for callers and have a getter function listed in the
164 // "Tab Helpers" section in the member functions area, above.) 167 // "Tab Helpers" section in the member functions area, above.)
165 168
166 scoped_ptr<AutocompleteHistoryManager> autocomplete_history_manager_; 169 scoped_ptr<AutocompleteHistoryManager> autocomplete_history_manager_;
167
168 scoped_ptr<AutofillManager> autofill_manager_; 170 scoped_ptr<AutofillManager> autofill_manager_;
169
170 scoped_ptr<ExtensionTabHelper> extension_tab_helper_; 171 scoped_ptr<ExtensionTabHelper> extension_tab_helper_;
171 172 scoped_ptr<FaviconTabHelper> favicon_tab_helper_;
172 scoped_ptr<FindTabHelper> find_tab_helper_; 173 scoped_ptr<FindTabHelper> find_tab_helper_;
173 174
174 // PasswordManager and its delegate. The delegate must outlive the manager, 175 // PasswordManager and its delegate. The delegate must outlive the manager,
175 // per documentation in password_manager.h. 176 // per documentation in password_manager.h.
176 scoped_ptr<PasswordManagerDelegate> password_manager_delegate_; 177 scoped_ptr<PasswordManagerDelegate> password_manager_delegate_;
177 scoped_ptr<PasswordManager> password_manager_; 178 scoped_ptr<PasswordManager> password_manager_;
178 179
179 scoped_ptr<SearchEngineTabHelper> search_engine_tab_helper_; 180 scoped_ptr<SearchEngineTabHelper> search_engine_tab_helper_;
180 181
181 // Per-tab observers --------------------------------------------------------- 182 // Per-tab observers ---------------------------------------------------------
182 // (These provide no API for callers; objects that need to exist 1:1 with tabs 183 // (These provide no API for callers; objects that need to exist 1:1 with tabs
183 // and silently do their thing live here.) 184 // and silently do their thing live here.)
184 185
185 scoped_ptr<DevToolsObserver> dev_tools_observer_; 186 scoped_ptr<DevToolsObserver> dev_tools_observer_;
186 scoped_ptr<ExtensionMessageObserver> extension_message_observer_; 187 scoped_ptr<ExtensionMessageObserver> extension_message_observer_;
187 scoped_ptr<FileSelectObserver> file_select_observer_; 188 scoped_ptr<FileSelectObserver> file_select_observer_;
188 scoped_ptr<prerender::PrerenderObserver> prerender_observer_; 189 scoped_ptr<prerender::PrerenderObserver> prerender_observer_;
189 190
190 // TabContents (MUST BE LAST) ------------------------------------------------ 191 // TabContents (MUST BE LAST) ------------------------------------------------
191 192
192 // The supporting objects need to outlive the TabContents dtor (as they may 193 // The supporting objects need to outlive the TabContents dtor (as they may
193 // be called upon during its execution). As a result, this must come last 194 // be called upon during its execution). As a result, this must come last
194 // in the list. 195 // in the list.
195 scoped_ptr<TabContents> tab_contents_; 196 scoped_ptr<TabContents> tab_contents_;
196 197
197 DISALLOW_COPY_AND_ASSIGN(TabContentsWrapper); 198 DISALLOW_COPY_AND_ASSIGN(TabContentsWrapper);
198 }; 199 };
199 200
200 #endif // CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_ 201 #endif // CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc ('k') | chrome/browser/ui/tab_contents/tab_contents_wrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698