Replace include with forward declarations....

Replace include with forward declarations.

Remove #import ApplicationServices.h from
platform_device_mac.h, and add it back to
appropriate .cc files.

This is motivated by a conflict between
headers included by ApplicationServices.h and
WebCore headers. The conflict occurs in
WebMediaPlayerClientImpl.cpp if it
modified to include platform_canvas.h.

With this change, ReleaseBitmapContext() cannot
be declared inline in the header, so it is moved
to bitmap_platform_device_mac.cc.

There is no functional change.

This requires that http://trac.webkit.org/changeset/81979
land in the Chromium tree first. (81979 has landed
in the WebKit tree.)

BUG=none
TEST=none

[brettw, 2011-03-24 19:50:46]

LGTM

[reed1, 2011-03-24 20:18:54]

I'll try locally installing this, and running the try bots

http://codereview.chromium.org/6732027/diff/1/skia/ext/platform_device_mac.h
File skia/ext/platform_device_mac.h (right):

http://codereview.chromium.org/6732027/diff/1/skia/ext/platform_device_mac.h#...
skia/ext/platform_device_mac.h:12: typedef struct CGRect CGRect;
Is this sufficient for CGRect?

struct CGRect;

[cary, 2011-03-24 20:34:26]

WebNetscapePluginEventHandler.h and WebKitSystemInterface.h use struct CGRect;
IntRect.h and FloatRect.h use typedef struct CGRect CGRect;
I chose to match the latter arbitrarily.

On 2011/03/24 20:18:54, reed1 wrote:
> I'll try locally installing this, and running the try bots
> 
> http://codereview.chromium.org/6732027/diff/1/skia/ext/platform_device_mac.h
> File skia/ext/platform_device_mac.h (right):
> 
>
http://codereview.chromium.org/6732027/diff/1/skia/ext/platform_device_mac.h#...
> skia/ext/platform_device_mac.h:12: typedef struct CGRect CGRect;
> Is this sufficient for CGRect?
> 
> struct CGRect;

[caryclark, 2011-04-07 19:03:06]

The WebKit dependency has landed, and the patch above successfully builds and
runs. What's needed to land this patch?

[brettw, 2011-04-07 23:42:09]

You just need to harass somebody to check it in for you. I can do it when I come
in tomorrow if it hasn't been done by then.