Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 6731086: CHROMIUM: gobi: resubmit interrupt urb on failed reads (Closed)

Created:
9 years, 8 months ago by Elly Fong-Jones
Modified:
9 years, 3 months ago
Reviewers:
Jason Glasgow
CC:
chromium-os-reviews_chromium.org, vb+kernel_google.com, Olof Johansson, sleffler+cc_chromium.org, msb+croskernel_chromium.org
Visibility:
Public.

Description

CHROMIUM: gobi: resubmit interrupt urb on failed reads If we don't do this and there are pending reads when the card suspends, we can fail to re-request interrupt urbs when the card comes back up, and we fall into a hole. Oops. BUG=None TEST=Adhoc suspend/resume a few times; make sure 'modem status' is sensible after each. Change-Id: Ia0e1b96e983249113c1e1dbf35490487f60a205c Signed-off-by: Elly Jones <ellyjones@chromium.org>; Signed-off-by: Jason Glasgow <jglasgow@chromium.org>; Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=900b6e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M drivers/net/usb/gobi/qmidevice.c View 7 chunks +24 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elly Fong-Jones
9 years, 8 months ago (2011-03-30 14:27:49 UTC) #1
Jason Glasgow
9 years, 8 months ago (2011-03-30 15:54:49 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698