Accompany debugger commands with senders data

As long as all debugger messages are handled by a single static method we need a way to identify request sender to route the response to the right handler. To accomplish this clients can send some additional data along with command text and debugger will later pass this data to the message handler along with the response text.


Committed: http://code.google.com/p/v8/source/detail?r=1755

[Søren Thygesen Gjesse, 2009-04-17 22:17:20]

LGTM

Thank you for cleaning this up.

You will need to look at the tests in test-debug.cc though.

http://codereview.chromium.org/67266/diff/1/2
File include/v8-debug.h (right):

http://codereview.chromium.org/67266/diff/1/2#newcode81
Line 81: class Deletable {
How about another name like ClientData or UserData, even though calling stuff
XXXData is a bit awkward. Also add a comment saying that V8 will always delete
this.

http://codereview.chromium.org/67266/diff/1/2#newcode142
Line 142: static void SetMessageHandler(DebugMessageHandler handler, void* data
= NULL,
As discussed offline remove this data parameter.

http://codereview.chromium.org/67266/diff/1/2#newcode148
Line 148: static void SetHostDispatchHandler(DebugHostDispatchHandler handler,
Also get rid of this data parameter.

[yurys, 2009-04-19 23:38:58]

* Addressed the comments
* made necessary changes to the unit tests
* fixed an issue with the queue expanding(it would dispose of its messages when
expanding) 
* added 2 new unit tests for the queue expanding and client data handling

http://codereview.chromium.org/67266/diff/1/2
File include/v8-debug.h (right):

http://codereview.chromium.org/67266/diff/1/2#newcode81
Line 81: class Deletable {
On 2009/04/17 22:17:21, Søren Gjesse wrote:
> How about another name like ClientData or UserData, even though calling stuff
> XXXData is a bit awkward. Also add a comment saying that V8 will always delete
> this.

Done. Renamed to ClientData

http://codereview.chromium.org/67266/diff/1/2#newcode142
Line 142: static void SetMessageHandler(DebugMessageHandler handler, void* data
= NULL,
On 2009/04/17 22:17:21, Søren Gjesse wrote:
> As discussed offline remove this data parameter.

Done.

http://codereview.chromium.org/67266/diff/1/2#newcode148
Line 148: static void SetHostDispatchHandler(DebugHostDispatchHandler handler,
On 2009/04/17 22:17:21, Søren Gjesse wrote:
> Also get rid of this data parameter.

Done.

[Søren Thygesen Gjesse, 2009-04-20 07:40:54]

LGTM

http://codereview.chromium.org/67266/diff/2001/2002
File include/v8-debug.h (right):

http://codereview.chromium.org/67266/diff/2001/2002#newcode85
Line 85: class ClientData {
I think we should put this class inside class Debug.

[yurys, 2009-04-21 10:53:20]

http://codereview.chromium.org/67266/diff/2001/2002
File include/v8-debug.h (right):

http://codereview.chromium.org/67266/diff/2001/2002#newcode85
Line 85: class ClientData {
On 2009/04/20 07:40:55, Søren Gjesse wrote:
> I think we should put this class inside class Debug.

Done. Also moved handler types into class Debug.

[Søren Thygesen Gjesse, 2009-04-21 10:58:07]

LGTM

[Søren Thygesen Gjesse, 2009-04-21 13:31:57]

LGTM

When we rool DEPS for chrome it should be bundled with this patch.

How about the current beta branch. We need to have a patch for that as well to
be able to roll V8 DEPS there.

[Søren Thygesen Gjesse, 2009-04-21 13:38:13]

Ignore my latest message it was supposed to go with another CL.

On 2009/04/21 13:31:57, Søren Gjesse wrote:
> LGTM
> 
> When we rool DEPS for chrome it should be bundled with this patch.
> 
> How about the current beta branch. We need to have a patch for that as well to
> be able to roll V8 DEPS there.