Remove authenticated_ fields from stubs.

remoting/protocol/connection_to_client.h

Index: remoting/protocol/connection_to_client.h
diff --git a/remoting/protocol/connection_to_client.h b/remoting/protocol/connection_to_client.h
index 0196f84a827cd30514651be17a9578436e63ead6..4ce88571801dcda31b0d70d9b4f0eccb207c4dde 100644
--- a/remoting/protocol/connection_to_client.h
+++ b/remoting/protocol/connection_to_client.h
@@ -47,10 +47,9 @@ class ConnectionToClient :
   // Constructs a ConnectionToClient object. |message_loop| is the message loop
   // that this object runs on. A viewer object receives events and messages from
   // a libjingle channel, these events are delegated to |handler|.
-  // It is guranteed that |handler| is called only on the |message_loop|.
+  // It is guaranteed that |handler| is called only on the |message_loop|.
   ConnectionToClient(MessageLoop* message_loop,
-                     EventHandler* handler,
-                     InputStub* input_stub);
+                     EventHandler* handler);
 
   virtual void Init(Session* session);
 
@@ -72,11 +71,7 @@ class ConnectionToClient :
   virtual HostStub* host_stub();
   virtual void set_host_stub(HostStub* host_stub);
 
-  // Called when the host accepts the client authentication.
-  void OnClientAuthenticated();
-
-  // Whether the client has been authenticated.
-  bool client_authenticated();
+  virtual void set_input_stub(InputStub* input_stub);

[Alpha Left Google, 2011/03/28 16:22:26]

do we need a getter like host stub?

[Alpha Left Google, 2011/03/28 16:22:26]

Since we have these setters now for stubs, need to add comments to explain when
we can call this setter, or should we set them before calling Init()?

[simonmorris, 2011/03/29 17:07:51]

It turns out we don't need a host_stub_ getter, either,
so I've removed it.

[simonmorris, 2011/03/29 17:07:51]

Added comments.

 
  protected:

[Alpha Left Google, 2011/03/28 16:22:26]

Can we not have protected here?

[simonmorris, 2011/03/29 17:07:51]

MockConnectionToClient inherits from ConnectionToClient.
I'm not sure whether that's a good thing, but it means
this dtor can't be private.

   friend class base::RefCountedThreadSafe<ConnectionToClient>;
@@ -91,11 +86,6 @@ class ConnectionToClient :
 
   void OnClosed();
 
-  // Initially false, this is set to true once the client has authenticated
-  // properly. When this is false, many client messages (like input events)
-  // will be ignored.
-  bool client_authenticated_;
-
   // The libjingle channel used to send and receive data from the remote client.
   scoped_refptr<Session> session_;