Remove authenticated_ fields from stubs.

remoting/protocol/connection_to_client.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_CONNECTION_TO_CLIENT_H_
 #define REMOTING_PROTOCOL_CONNECTION_TO_CLIENT_H_
 
 #include <deque>
 #include <vector>
 
@@ skipping 29 matching lines @@
     // Called when the network connection is closed.
     virtual void OnConnectionClosed(ConnectionToClient* connection) = 0;
 
     // Called when the network connection has failed.
     virtual void OnConnectionFailed(ConnectionToClient* connection) = 0;
   };
 
   // Constructs a ConnectionToClient object. |message_loop| is the message loop
   // that this object runs on. A viewer object receives events and messages from
   // a libjingle channel, these events are delegated to |handler|.
-  // It is guranteed that |handler| is called only on the |message_loop|.
+  // It is guaranteed that |handler| is called only on the |message_loop|.
   ConnectionToClient(MessageLoop* message_loop,
-                     EventHandler* handler,
-                     InputStub* input_stub);
+                     EventHandler* handler);
 
   virtual void Init(Session* session);
 
   // Returns the connection in use.
   virtual Session* session();
 
   // Disconnect the client connection. This method is allowed to be called
   // more than once and calls after the first one will be ignored.
   //
   // After this method is called all the send method calls will be ignored.
   virtual void Disconnect();
 
   // Send encoded update stream data to the viewer.
   virtual VideoStub* video_stub();
 
   // Return pointer to ClientStub.
   virtual ClientStub* client_stub();
 
   virtual HostStub* host_stub();
   virtual void set_host_stub(HostStub* host_stub);
 
-  // Called when the host accepts the client authentication.
-  void OnClientAuthenticated();
-
-  // Whether the client has been authenticated.
-  bool client_authenticated();
+  virtual void set_input_stub(InputStub* input_stub);

[Alpha Left Google, 2011/03/28 16:22:26]

do we need a getter like host stub?

[Alpha Left Google, 2011/03/28 16:22:26]

Since we have these setters now for stubs, need to add comments to explain when
we can call this setter, or should we set them before calling Init()?

[simonmorris, 2011/03/29 17:07:51]

It turns out we don't need a host_stub_ getter, either,
so I've removed it.

[simonmorris, 2011/03/29 17:07:51]

Added comments.

 
  protected:

[Alpha Left Google, 2011/03/28 16:22:26]

Can we not have protected here?

[simonmorris, 2011/03/29 17:07:51]

MockConnectionToClient inherits from ConnectionToClient.
I'm not sure whether that's a good thing, but it means
this dtor can't be private.

   friend class base::RefCountedThreadSafe<ConnectionToClient>;
   virtual ~ConnectionToClient();
 
  private:
   // Callback for protocol Session.
   void OnSessionStateChange(Session::State state);
 
   // Process a libjingle state change event on the |loop_|.
   void StateChangeTask(Session::State state);
 
   void OnClosed();
 
-  // Initially false, this is set to true once the client has authenticated
-  // properly. When this is false, many client messages (like input events)
-  // will be ignored.
-  bool client_authenticated_;
-
   // The libjingle channel used to send and receive data from the remote client.
   scoped_refptr<Session> session_;
 
   scoped_ptr<VideoWriter> video_writer_;
 
   // ClientStub for sending messages to the client.
   scoped_ptr<ClientStub> client_stub_;
 
   // The message loop that this object runs on.
   MessageLoop* loop_;
@@ skipping 10 matching lines @@
   // Dispatcher for submitting messages to stubs.
   scoped_ptr<HostMessageDispatcher> dispatcher_;
 
   DISALLOW_COPY_AND_ASSIGN(ConnectionToClient);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_CONNECTION_TO_CLIENT_H_