Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: remoting/protocol/connection_to_client.h

Issue 6724033: Remove authenticated_ fields from stubs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address reviewer's comments. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/client_stub.cc ('k') | remoting/protocol/connection_to_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/connection_to_client.h
diff --git a/remoting/protocol/connection_to_client.h b/remoting/protocol/connection_to_client.h
index 0196f84a827cd30514651be17a9578436e63ead6..19dbdf5a7084158f2e2a1cb1ee47d237bd1dc95c 100644
--- a/remoting/protocol/connection_to_client.h
+++ b/remoting/protocol/connection_to_client.h
@@ -47,10 +47,9 @@ class ConnectionToClient :
// Constructs a ConnectionToClient object. |message_loop| is the message loop
// that this object runs on. A viewer object receives events and messages from
// a libjingle channel, these events are delegated to |handler|.
- // It is guranteed that |handler| is called only on the |message_loop|.
+ // It is guaranteed that |handler| is called only on the |message_loop|.
ConnectionToClient(MessageLoop* message_loop,
- EventHandler* handler,
- InputStub* input_stub);
+ EventHandler* handler);
virtual void Init(Session* session);
@@ -69,14 +68,9 @@ class ConnectionToClient :
// Return pointer to ClientStub.
virtual ClientStub* client_stub();
- virtual HostStub* host_stub();
+ // These two setters should be called before Init().
virtual void set_host_stub(HostStub* host_stub);
-
- // Called when the host accepts the client authentication.
- void OnClientAuthenticated();
-
- // Whether the client has been authenticated.
- bool client_authenticated();
+ virtual void set_input_stub(InputStub* input_stub);
protected:
friend class base::RefCountedThreadSafe<ConnectionToClient>;
@@ -91,11 +85,6 @@ class ConnectionToClient :
void OnClosed();
- // Initially false, this is set to true once the client has authenticated
- // properly. When this is false, many client messages (like input events)
- // will be ignored.
- bool client_authenticated_;
-
// The libjingle channel used to send and receive data from the remote client.
scoped_refptr<Session> session_;
« no previous file with comments | « remoting/protocol/client_stub.cc ('k') | remoting/protocol/connection_to_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698