Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 6723004: ChromeDriver should be able to focus on a frame using its frame element, (Closed)

Created:
9 years, 9 months ago by Jason Leyba
Modified:
9 years, 7 months ago
Reviewers:
kkania
CC:
chromium-reviews, kkania, Paweł Hajdan Jr.
Visibility:
Public.

Description

Several bug fixes for the ChromeDriver: - Should be able to focus on a frame using its frame element, not just an ID, name, or index. - Element equality checks now work properly - Session-level command handlers should be registered with mongoose after the element handlers to avoid clashes from greedy wildcard matching. - Remove spam from test logs by returning 204 on favicon requests instead of returning 404. This change also updates src/third_party/webdriver/python to r11767. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79492

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -24 lines) Patch
M DEPS View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/WEBDRIVER_TESTS View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/webdriver/chromedriver_tests.py View 1 3 chunks +34 lines, -0 lines 2 comments Download
M chrome/test/webdriver/commands/find_element_commands.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/webdriver/commands/target_locator_commands.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/test/webdriver/commands/target_locator_commands.cc View 1 4 chunks +22 lines, -0 lines 0 comments Download
M chrome/test/webdriver/commands/webelement_commands.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/webdriver/dispatch.cc View 1 2 chunks +14 lines, -1 line 0 comments Download
M chrome/test/webdriver/server.cc View 1 2 chunks +25 lines, -18 lines 0 comments Download
M chrome/test/webdriver/session.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/webdriver/session.cc View 1 2 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Jason Leyba
9 years, 9 months ago (2011-03-22 21:20:36 UTC) #1
kkania
fyi, all the files aren't here; I'll wait until you publish again
9 years, 9 months ago (2011-03-22 22:12:24 UTC) #2
Jason Leyba
On 2011/03/22 22:12:24, kkania wrote: > fyi, all the files aren't here; I'll wait until ...
9 years, 9 months ago (2011-03-23 17:51:52 UTC) #3
kkania
http://codereview.chromium.org/6723004/diff/4001/chrome/test/webdriver/chromedriver_tests.py File chrome/test/webdriver/chromedriver_tests.py (right): http://codereview.chromium.org/6723004/diff/4001/chrome/test/webdriver/chromedriver_tests.py#newcode300 chrome/test/webdriver/chromedriver_tests.py:300: how about a test for switching to a frame ...
9 years, 9 months ago (2011-03-24 17:19:33 UTC) #4
Jason Leyba
http://codereview.chromium.org/6723004/diff/4001/chrome/test/webdriver/chromedriver_tests.py File chrome/test/webdriver/chromedriver_tests.py (right): http://codereview.chromium.org/6723004/diff/4001/chrome/test/webdriver/chromedriver_tests.py#newcode300 chrome/test/webdriver/chromedriver_tests.py:300: On 2011/03/24 17:19:33, kkania wrote: > how about a ...
9 years, 9 months ago (2011-03-24 17:27:53 UTC) #5
kkania
9 years, 9 months ago (2011-03-24 17:47:48 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698