Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/webdriver/commands/webelement_commands.cc

Issue 6723004: ChromeDriver should be able to focus on a frame using its frame element, (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/webdriver/chromedriver_tests.py ('K') | « chrome/test/webdriver/commands/target_locator_commands.cc ('k') | chrome/test/webdriver/dispatch.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/commands/webelement_commands.cc
===================================================================
--- chrome/test/webdriver/commands/webelement_commands.cc (revision 79141)
+++ chrome/test/webdriver/commands/webelement_commands.cc (working copy)
@@ -219,8 +219,10 @@
scoped_ptr<ListValue> args(new ListValue);
args->Append(element.ToValue());
- args->Append(Value::CreateStringValue(path_segments_.at(6)));
+ WebElementId other_element(path_segments_.at(6));
+ args->Append(other_element.ToValue());
+
Value* result = NULL;
ErrorCode status = session_->ExecuteScript(script, args.get(), &result);
response->SetStatus(status);
« chrome/test/webdriver/chromedriver_tests.py ('K') | « chrome/test/webdriver/commands/target_locator_commands.cc ('k') | chrome/test/webdriver/dispatch.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698