Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 6722017: crash-reporter: Don't send ps command lines with crash reporter (Closed)

Created:
9 years, 9 months ago by Michael Krebs
Modified:
9 years, 3 months ago
Reviewers:
kmixter1
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

crash-reporter: Don't send ps command lines with crash reporter When unable to generate a crash, don't show the commands' arguments with 'ps' because they may contain PII. Change-Id: I1e2f40e59535f4de08f43012727ab8e92bad8a0d BUG=chromium-os:13206 TEST=unit tests, logging_UserCrash autotest Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=78599c9

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M crash_reporter_logs.conf View 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Michael Krebs
Here's the CL for the 'ps' change.
9 years, 9 months ago (2011-03-23 02:58:35 UTC) #1
kmixter1
Please add TEST= stanza. You should run at least unit tests and logging_UserCrash autotest. Also, ...
9 years, 9 months ago (2011-03-23 03:57:26 UTC) #2
Michael Krebs
How's this...
9 years, 9 months ago (2011-03-23 22:30:07 UTC) #3
kmixter1
9 years, 9 months ago (2011-03-24 22:35:53 UTC) #4
LGTM

http://codereview.chromium.org/6722017/diff/1/crash_reporter_logs.conf
File crash_reporter_logs.conf (right):

http://codereview.chromium.org/6722017/diff/1/crash_reporter_logs.conf#newcode23
crash_reporter_logs.conf:23: # same as with the "u" ("user-oriented") option,
except it doesn't show
can't tell by the diff but are there a bunch of trailing spaces?

Powered by Google App Engine
This is Rietveld 408576698