Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1818)

Unified Diff: crash_reporter_logs.conf

Issue 6722017: crash-reporter: Don't send ps command lines with crash reporter (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crash-reporter.git@master
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crash_reporter_logs.conf
diff --git a/crash_reporter_logs.conf b/crash_reporter_logs.conf
index 192198345ee92a3be452759d5c6f1d84fd821b5f..62c6216a08efc0f689b0db005c298c806670c12a 100644
--- a/crash_reporter_logs.conf
+++ b/crash_reporter_logs.conf
@@ -19,8 +19,10 @@ update_engine:cat $(ls -1tr /var/log/update_engine | tail -5 | sed s.^./var/log/
# The following rule is used for generating additional diagnostics when
# collection of user crashes fails. This output should not be too large
-# as it is stored in memory.
-crash_reporter-user-collection:echo "===ps output==="; ps auxw | tail -c 25000; echo "===dmesg output==="; dmesg | tail -c 25000; echo "===meminfo==="; cat /proc/meminfo
+# as it is stored in memory. The output format specified for 'ps' is the
+# same as with the "u" ("user-oriented") option, except it doesn't show
kmixter1 2011/03/24 22:35:53 can't tell by the diff but are there a bunch of tr
+# the commands' arguments (i.e. "comm" instead of "command").
+crash_reporter-user-collection:echo "===ps output==="; ps axw -o user,pid,%cpu,%mem,vsz,rss,tname,stat,start_time,bsdtime,comm | tail -c 25000; echo "===dmesg output==="; dmesg | tail -c 25000; echo "===meminfo==="; cat /proc/meminfo
# The following rules are only for testing purposes.
crash_log_test:echo hello world
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698